From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqehX-0008Qo-7b for qemu-devel@nongnu.org; Wed, 11 Dec 2013 02:59:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqehN-0006zO-1k for qemu-devel@nongnu.org; Wed, 11 Dec 2013 02:59:23 -0500 Received: from mail-pd0-f175.google.com ([209.85.192.175]:42828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqehM-0006zI-RX for qemu-devel@nongnu.org; Wed, 11 Dec 2013 02:59:12 -0500 Received: by mail-pd0-f175.google.com with SMTP id w10so8962539pde.6 for ; Tue, 10 Dec 2013 23:59:12 -0800 (PST) Message-ID: <52A81B48.8090407@ozlabs.ru> Date: Wed, 11 Dec 2013 18:59:04 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1385364460-24332-1-git-send-email-aik@ozlabs.ru> <1385364460-24332-3-git-send-email-aik@ozlabs.ru> <529DA675.8030705@redhat.com> <529DE041.70006@suse.de> <529DE3F0.2050101@redhat.com> <529DEC1A.2030306@suse.de> <529DF195.3090107@redhat.com> <52A7F622.4040203@ozlabs.ru> <52A818A0.9090309@redhat.com> In-Reply-To: <52A818A0.9090309@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Crosthwaite , Nikunj A Dadhania , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Anthony Liguori , Paul Mackerras , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= On 12/11/2013 06:47 PM, Paolo Bonzini wrote: > Il 11/12/2013 06:20, Alexey Kardashevskiy ha scritto: >> >> Any progress on this? >> >> I am asking since the patchset about bootindex you gave me yesterday prints >> "(process:38896): GLib-CRITICAL **: g_hash_table_foreach: assertion >> `version == hash_table->version' failed" which I "fixed" by moving the >> machine object creation chunk before kvm_init() in vl.c. >> >> btw what do I do with that patchset now? I works for me (except the issue >> above), do I have to repost it again? Thanks. > > Please do, but we need to sort out the get_fw_dev_path suffixes first. > I'll be on IRC in ~1 hour. And this is not it, "make check" on x86 fails: GTESTER tests/test-bitops LINK tests/test-qdev-global-props hw/core/qdev.o: In function `qdev_get_fw_dev_path_from_handler': /home/alexey/p/qemu/hw/core/qdev.c:514: undefined reference to `fw_path_provider_try_get_dev_path' collect2: error: ld returned 1 exit status -- Alexey