From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqnhx-0007pI-6O for qemu-devel@nongnu.org; Wed, 11 Dec 2013 12:36:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vqnhs-0008Cn-6R for qemu-devel@nongnu.org; Wed, 11 Dec 2013 12:36:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqnhr-0008Ce-U8 for qemu-devel@nongnu.org; Wed, 11 Dec 2013 12:36:20 -0500 Message-ID: <52A8A28E.1060703@redhat.com> Date: Wed, 11 Dec 2013 10:36:14 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386755260-13781-1-git-send-email-ghammer@redhat.com> In-Reply-To: <1386755260-13781-1-git-send-email-ghammer@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DN5a0U3unLkmtl1OTcPChQnk2g8awXtdi" Subject: Re: [Qemu-devel] [PATCH v2] char: restore read callback on a reattached (hotplug) chardev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer , qemu-devel@nongnu.org Cc: Amit Shah , Anthony Liguori This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DN5a0U3unLkmtl1OTcPChQnk2g8awXtdi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/11/2013 02:47 AM, Gal Hammer wrote: > Fix a bug that was introduced in commit 386a5a1e. A removal of a device= > set the chr handlers to NULL. However when the device is plugged back, > its read callback is not restored so data can't be transfter from the s/transfter/transferred/ > host to the guest via the virtio-serial port. >=20 > https://bugzilla.redhat.com/show_bug.cgi?id=3D1027181 The S-o-B tag below, and the commit message up to here is fine... >=20 > V2: - do not call chr_update_read_handler on device removal. > - add asserts to verify chr_update_read_handler is not called > with an assigned fd_in_tag to prevent fd leaks. > - update fd and udp backends' chr_update_read_handler function > so it won't remove fd_in to prevent a double release. =2E..whereas this version information belongs better... >=20 > Signed-off-by: Gal Hammer > --- =2E..here, after the --- separator. It's useful information to reviewers= , but in this location, 'git am' will strip it, as in the long run, someone reading 'git log' history doesn't care about how many revisions a patch took or what changed from the earlier versions of the patch, since none of the earlier versions are stored in git. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DN5a0U3unLkmtl1OTcPChQnk2g8awXtdi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSqKKOAAoJEKeha0olJ0NqlPEH/2Au0m3aONCO8bGZUSk40WQX 38LryRryTZCjdUO5935/GoQskmQcutH6VF8k0LnLaVVzi6CTAQF/tqv5V3NubiL/ y4fFgGBVk3Fv3Wu8/FTJm5NMKeABvlbzpzg5VKe96ViI6s1YWuordIFSnvCsVdhY +cTHnRIZ8onflu5dYoOyFU/oc8XKK+De84uAk1Gki29YyXeHGWnN3OD6cI/QQc7X Ni/tTiHQgvdDxyNkT/pK/QOZhkY5nuZKILNO8X9zv0zHmLnv/gX96eQWWL99lIWQ atbfJBwm7zL7EZQtfAwxGQ2UmfOeWRdRc0qYXvWAFvSb4DvND6QMKaqgf4eT0oI= =k4Cj -----END PGP SIGNATURE----- --DN5a0U3unLkmtl1OTcPChQnk2g8awXtdi--