From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqopm-0006en-QU for qemu-devel@nongnu.org; Wed, 11 Dec 2013 13:48:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vqopi-0007SZ-7E for qemu-devel@nongnu.org; Wed, 11 Dec 2013 13:48:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqoph-0007SQ-Uh for qemu-devel@nongnu.org; Wed, 11 Dec 2013 13:48:30 -0500 Message-ID: <52A8B378.80309@redhat.com> Date: Wed, 11 Dec 2013 11:48:24 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386764361-15260-1-git-send-email-pbonzini@redhat.com> <1386764361-15260-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1386764361-15260-3-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HMKnHr8rwHRH6E2U06RNOlAJRa4JvJDDI" Subject: Re: [Qemu-devel] [RFC PATCH 02/14] NUMA: check if the total numa memory size is equal to ram_size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: imammedo@redhat.com, stefanha@redhat.com, gaowanlong@cn.fujitsu.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HMKnHr8rwHRH6E2U06RNOlAJRa4JvJDDI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/11/2013 05:19 AM, Paolo Bonzini wrote: > From: Wanlong Gao >=20 > If the total number of the assigned numa nodes memory is not > equal to the assigned ram size, it will write the wrong data > to ACPI talb, then the guest will ignore the wrong ACPI table s/talb/table/ > and recognize all memory to one node. It's buggy, we should > check it to ensure that we write the right data to ACPI table. >=20 > Signed-off-by: Wanlong Gao > Signed-off-by: Paolo Bonzini > --- > numa.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > + } > + if (numa_total !=3D ram_size) { > + fprintf(stderr, "qemu: numa nodes total memory size " > + "should equal to ram_size\n"); s/to // --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HMKnHr8rwHRH6E2U06RNOlAJRa4JvJDDI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSqLN4AAoJEKeha0olJ0Nq0MAH/3/9n4VaP1gKnHlOlkyE/O5c kaQoSqzWyeKyewlIoxB20LZ8zuLDWmbTNBWA0v9qVNi1HmLTh0gB4ouHVPOaDX2D VBApmeSd71qaKOHNeBwIAD3IpJZTZ2XwowEUo9rWjsYfor5UaCbhM/h9YrbiXe+P PnOfJ7ADPQtBydVr5n09KMvDLKS6NLDFIWCyAJxCGItyiB4dz/zDrzXwjedzvfuv uCsWmd53bFejmpHDmR6bIGieHOoPSd7jBnMRkNgv2dJZmQ6Xm5EtOte6W+W+nMMk VCcqzcQO1mSpw2v0V5uRHpU71NVdpKBVEzFfE+Z1uzDPd5p8zLmun/681cSFnaQ= =XDmr -----END PGP SIGNATURE----- --HMKnHr8rwHRH6E2U06RNOlAJRa4JvJDDI--