From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqosp-000847-Cm for qemu-devel@nongnu.org; Wed, 11 Dec 2013 13:51:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vqosl-00083R-5w for qemu-devel@nongnu.org; Wed, 11 Dec 2013 13:51:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqosk-00083N-Tn for qemu-devel@nongnu.org; Wed, 11 Dec 2013 13:51:39 -0500 Message-ID: <52A8B436.9030301@redhat.com> Date: Wed, 11 Dec 2013 11:51:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386764361-15260-1-git-send-email-pbonzini@redhat.com> <1386764361-15260-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1386764361-15260-5-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="riBj6KQkV0MK3QnawbcjxEMssxiNmeguI" Subject: Re: [Qemu-devel] [RFC PATCH 04/14] NUMA: convert -numa option to use OptsVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: imammedo@redhat.com, stefanha@redhat.com, gaowanlong@cn.fujitsu.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --riBj6KQkV0MK3QnawbcjxEMssxiNmeguI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/11/2013 05:19 AM, Paolo Bonzini wrote: > From: Wanlong Gao >=20 > Signed-off-by: Wanlong Gao > Signed-off-by: Paolo Bonzini > --- > +++ b/qapi-schema.json > @@ -4235,3 +4235,33 @@ > # Since: 1.7 > ## > { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } = } > + > +## > +# @NumaOptions > +# > +# A discriminated record of NUMA options. (for OptsVisitor) > +# > +# Since 2.0 > +## > +{ 'union': 'NumaOptions', > + 'data': { > + 'node': 'NumaNodeOptions' }} Why do we need a union, if there's no alternative, and since nothing else in the series adds an alternative? > + > +## > +# @NumaNodeOptions > +# > +# Create a guest NUMA node. (for OptsVisitor) > +# > +# @nodeid: #optional NUMA node ID > +# > +# @cpus: #optional VCPUs belong to this node What are the defaults if these fields are omitted? > +# > +# @mem: #optional memory size of this node In bytes? Why is this field a string instead of an integer? > +# > +# Since: 2.0 > +## > +{ 'type': 'NumaNodeOptions', > + 'data': { > + '*nodeid': 'uint16', > + '*cpus': ['uint16'], > + '*mem': 'str' }} --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --riBj6KQkV0MK3QnawbcjxEMssxiNmeguI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSqLQ2AAoJEKeha0olJ0NqOvgIAILHBK/DvI4caddz62SrYxI2 T1mnHclNpoSyTVUVZLhiSHOivHo1DqVl+pXqvvS81Ywuzcu/fx39t8/yJDOEkhuD hmMoOZu6luB8UTRtCKgmM/xxtTEiSoRbUjG0qLF+yQzEnWmUmTT2kvR4sy1ds7Oz EJ7hltGp1Yu8ii3ILlqs31jYMCOCdaAIzlrjF7YD0mQMiDxqEQ36/98YWRvQMJCn Zhp7ItN0QhNOGrkt/G7fhoYE6ovpY0Nn064GWhJiBAdVjeFRQ88+gpCjyrn/XXw2 IwVrnlJfGkDUj4rVJvgO74NiCJDNOr757spKOFDHlTX7PJ/k9+O4z5ee0CUYZHQ= =nKxa -----END PGP SIGNATURE----- --riBj6KQkV0MK3QnawbcjxEMssxiNmeguI--