* [Qemu-devel] [PATCH] tcg/i386: fix a comment
@ 2013-12-11 18:33 Aurelien Jarno
2013-12-11 19:04 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Aurelien Jarno @ 2013-12-11 18:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Aurelien Jarno, Richard Henderson
The comments apply to 8-bit stores, not 8-bit loads.
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
tcg/i386/tcg-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
index 7ac8e45..495b901 100644
--- a/tcg/i386/tcg-target.c
+++ b/tcg/i386/tcg-target.c
@@ -1486,7 +1486,7 @@ static void tcg_out_qemu_st_direct(TCGContext *s, TCGReg datalo, TCGReg datahi,
switch (memop & MO_SIZE) {
case MO_8:
- /* In 32-bit mode, 8-byte stores can only happen from [abcd]x.
+ /* In 32-bit mode, 8-bit stores can only happen from [abcd]x.
Use the scratch register if necessary. */
if (TCG_TARGET_REG_BITS == 32 && datalo >= 4) {
tcg_out_mov(s, TCG_TYPE_I32, scratch, datalo);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg/i386: fix a comment
2013-12-11 18:33 [Qemu-devel] [PATCH] tcg/i386: fix a comment Aurelien Jarno
@ 2013-12-11 19:04 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2013-12-11 19:04 UTC (permalink / raw)
To: Aurelien Jarno, qemu-devel
On 12/11/2013 10:33 AM, Aurelien Jarno wrote:
> The comments apply to 8-bit stores, not 8-bit loads.
>
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Ack on the actual code comment fix. The commit comment is wrong. ;-)
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-11 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-11 18:33 [Qemu-devel] [PATCH] tcg/i386: fix a comment Aurelien Jarno
2013-12-11 19:04 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).