From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1VqqYv-0005Ps-KQ
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 15:39:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1VqqYn-0000s6-7U
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 15:39:17 -0500
Message-ID: <52A8CD67.8060804@gmail.com>
Date: Wed, 11 Dec 2013 14:39:03 -0600
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1386789398-5239-1-git-send-email-tommusta@gmail.com>
	<1386789398-5239-12-git-send-email-tommusta@gmail.com>
	<CAFEAcA_rY49bSr=GnC7rcjER6_WhkVG5WuwTR753xp11eZqMLQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_rY49bSr=GnC7rcjER6_WhkVG5WuwTR753xp11eZqMLQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V2 PATCH 11/18] softfloat: Fix float64_to_uint32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

On 12/11/2013 1:53 PM, Peter Maydell wrote:
> On 11 December 2013 19:16, Tom Musta <tommusta@gmail.com> wrote:
>>  uint32 float64_to_uint32( float64 a STATUS_PARAM )
>>  {
>> -    int64_t v;
>> +    uint64_t v;
>>      uint32 res;
>>
>> -    v = float64_to_int64(a STATUS_VAR);
>> -    if (v < 0) {
>> -        res = 0;
>> -        float_raise( float_flag_invalid STATUS_VAR);
>> -    } else if (v > 0xffffffff) {
>> +    v = float64_to_uint64(a STATUS_VAR);
>> +    if (v > 0xffffffff) {
>>          res = 0xffffffff;
>> +        STATUS(float_exception_flags) &= ~float_flag_inexact;
> 
> The IEEE exception flags are cumulative (ie never get cleared
> except by guest program explicit request); this change means
> that if a previous operation raised the inexact flag you've just
> lost that.
> 
> thanks
> -- PMM
> 
Thank you, Peter.  I will fix.