From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr3m2-0007iI-9Z for qemu-devel@nongnu.org; Thu, 12 Dec 2013 05:45:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vr3lw-0003Vf-8s for qemu-devel@nongnu.org; Thu, 12 Dec 2013 05:45:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr3lv-0003Va-Vp for qemu-devel@nongnu.org; Thu, 12 Dec 2013 05:45:36 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBCAjZb1031797 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 12 Dec 2013 05:45:35 -0500 Message-ID: <52A993C3.3000302@redhat.com> Date: Thu, 12 Dec 2013 18:45:23 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1386785473-26157-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1386785473-26157-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 00/21] blkdebug/blkverify: Allow QMP configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 2013=E5=B9=B412=E6=9C=8812=E6=97=A5 02:10, Max Reitz wrote: > Currently, the configuration of blkdebug and blkverify is done through > the "filename" alone. There is now way of manually choosing blkdebug or > blkverify as a driver and using a normal image filename. > > In the case of blkdebug, the filename starts with the protocol prefix, > follows up with the name of a configuration file and ends with the name > of the image file. > > In the case of blkverify, the filename starts with the protocol prefix, > follows up with the raw reference image filename and ends with the name > of the image file. > > This patch allows the configuration of both drivers completely through > QMP and accordingly command-line options. The driver has to be selected > through the driver option (or similar), the image filename may be given > either as the filename itself or through a x.filename option, where "x" > depends on the driver. Further options may be required depending on the > driver. > > In case of blkverify, the test image may be specified either through th= e > filename or as a BlockdevRef reference through the "test" option. The > raw image is referenced as "raw". > > In case of blkdebug, one may either set the "config" option to the > filename of a configuration file, or the content of the configuration > file may be given directly (as options). The image filename is either > specified as the filename or referenced through the "image" option. > > > v3: > - The first few patches are probably similar to the ones from the > previous series; but it's probably best to see this series as a > completely new one. > Reviewed the patches and also tried the test case. Looks good to me, I=20 have only a few questions in some patches. Thanks, Fam