From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr5RJ-0005UG-9F for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:32:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vr5RD-0002TY-AY for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:32:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr5RD-0002TQ-0y for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:32:19 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBCCWHGl014392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 12 Dec 2013 07:32:18 -0500 Message-ID: <52A9ACC6.8030308@redhat.com> Date: Thu, 12 Dec 2013 20:32:06 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1386836626-6436-1-git-send-email-famz@redhat.com> <1386836626-6436-2-git-send-email-famz@redhat.com> <20131212122115.GI10007@dhcp-200-207.str.redhat.com> In-Reply-To: <20131212122115.GI10007@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 01/10] qapi: Add BlockOperationType enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , eblake@redhat.com Cc: rjones@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On 2013=E5=B9=B412=E6=9C=8812=E6=97=A5 20:21, Kevin Wolf wrote: > Am 12.12.2013 um 09:23 hat Fam Zheng geschrieben: >> This adds the enum of all the operations that can be taken on a block >> device. >> >> Signed-off-by: Fam Zheng >> --- >> qapi-schema.json | 49 ++++++++++++++++++++++++++++++++++++++++++++++= +++ >> 1 file changed, 49 insertions(+) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index d6f8615..ef4d6af 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -1440,6 +1440,55 @@ >> 'data': ['commit', 'stream', 'mirror', 'backup'] } >> >> ## >> +# @BlockOperationType >> +# Type of a block operation. (since 1.8) > > I don't think this description is accurate any more. You now have a lis= t > of roles that a block device can take, or something like that. Not sure > what the best way to put it is. backup-source isn't an operation anyway= , > nor is dataplane. "Using this as backup source" or "start dataplane on that" still sounds=20 an operation to me. It's just the 1:1 corresponding with QMP commands=20 that is loosed, but not totally independent, as the long comments below=20 show. > > Also, should have an empty line after @BlockOperationType and 2.0 > instead of 1.8. > OK, will fix. Thanks. Fam