From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Gal Hammer <ghammer@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH v3] char: restore read callback on a reattached (hotplug) chardev
Date: Thu, 12 Dec 2013 08:46:08 -0700 [thread overview]
Message-ID: <52A9DA40.4090109@redhat.com> (raw)
In-Reply-To: <8761quffa3.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On 12/12/2013 05:02 AM, Markus Armbruster wrote:
> Gal Hammer <ghammer@redhat.com> writes:
>
>> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
>> set the chr handlers to NULL. However when the device is plugged back,
>> its read callback is not restored so data can't be transftered from the
[1]
>> host to the guest (e.g. via the virtio-serial port).
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1027181
>>
>> Signed-off-by: Gal Hammer <ghammer@redhat.com>
>>
>> V3: - fix a typo in comment.
>> - move the revision history after the "signed-off-by" tag.
>
> Close, but no cigar :)
Also, you missed my suggested typo fix at [1].
s/transftered/transferred/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
prev parent reply other threads:[~2013-12-12 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 7:55 [Qemu-devel] [PATCH v3] char: restore read callback on a reattached (hotplug) chardev Gal Hammer
2013-12-12 12:02 ` Markus Armbruster
2013-12-12 15:46 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9DA40.4090109@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=ghammer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).