From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr8Sx-0007QV-LY for qemu-devel@nongnu.org; Thu, 12 Dec 2013 10:46:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vr8Ss-0000as-QC for qemu-devel@nongnu.org; Thu, 12 Dec 2013 10:46:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr8Ss-0000ae-GE for qemu-devel@nongnu.org; Thu, 12 Dec 2013 10:46:14 -0500 Message-ID: <52A9DA40.4090109@redhat.com> Date: Thu, 12 Dec 2013 08:46:08 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386834932-2078-1-git-send-email-ghammer@redhat.com> <8761quffa3.fsf@blackfin.pond.sub.org> In-Reply-To: <8761quffa3.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GE5ojBmAwBt3NNGOnsMd4lDNJVxi7Rj3G" Subject: Re: [Qemu-devel] [PATCH v3] char: restore read callback on a reattached (hotplug) chardev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Gal Hammer Cc: Amit Shah , qemu-devel@nongnu.org, Anthony Liguori This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GE5ojBmAwBt3NNGOnsMd4lDNJVxi7Rj3G Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/12/2013 05:02 AM, Markus Armbruster wrote: > Gal Hammer writes: >=20 >> Fix a bug that was introduced in commit 386a5a1e. A removal of a devic= e >> set the chr handlers to NULL. However when the device is plugged back,= >> its read callback is not restored so data can't be transftered from th= e [1] >> host to the guest (e.g. via the virtio-serial port). >> >> https://bugzilla.redhat.com/show_bug.cgi?id=3D1027181 >> >> Signed-off-by: Gal Hammer >> >> V3: - fix a typo in comment. >> - move the revision history after the "signed-off-by" tag. >=20 > Close, but no cigar :) Also, you missed my suggested typo fix at [1]. s/transftered/transferred/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GE5ojBmAwBt3NNGOnsMd4lDNJVxi7Rj3G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSqdpAAAoJEKeha0olJ0NqGOkH/iCErXTTZvNn1Cwj/vo6sCBD DzeJwvik6ao6AinlggQ6+iZ2S0vX5N46nJP2B9gvnr5CKKjdL+uBRVfXsTpH4KCR ihYQ+pxRaliGZe12ltxtN2B+H1rWU1gyPyANoYoNrU3c16KsMtUHkJZgkkcmik2J ezjnDPPyBBGfNqFhROeyWbSomefK8YBGpy2xQqLFnv+s8+24kTmZykadhMz6D7Zi XnShaIqsRYY6FoL7Zhf3xXJ+9CN+xrZJrmwudrS0NJLuQD+T3APre/uyyIY/hzJD YZwPigKSD3+QNVQfg5nwlQU5q8hDS7DZNuzb74dZBNRwlydN+BRYdQ+pODyyFL4= =a93l -----END PGP SIGNATURE----- --GE5ojBmAwBt3NNGOnsMd4lDNJVxi7Rj3G--