From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VrIur-0006FQ-2Z
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 21:55:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VrIug-000400-Kc
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 21:55:49 -0500
Received: from e28smtp01.in.ibm.com ([122.248.162.1]:34548)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VrIuf-0003zT-Va
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 21:55:38 -0500
Received: from /spool/local
	by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Fri, 13 Dec 2013 08:25:32 +0530
Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58])
	by d28dlp03.in.ibm.com (Postfix) with ESMTP id EC5521258056
	for <qemu-devel@nongnu.org>; Fri, 13 Dec 2013 08:26:40 +0530 (IST)
Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63])
	by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	rBD2tM8i42270778
	for <qemu-devel@nongnu.org>; Fri, 13 Dec 2013 08:25:23 +0530
Received: from d28av01.in.ibm.com (localhost [127.0.0.1])
	by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	rBD2tTRF006090
	for <qemu-devel@nongnu.org>; Fri, 13 Dec 2013 08:25:29 +0530
Message-ID: <52AA7723.2090501@linux.vnet.ibm.com>
Date: Fri, 13 Dec 2013 10:55:31 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1386694828-19786-1-git-send-email-pbonzini@redhat.com>
	<1386694828-19786-5-git-send-email-pbonzini@redhat.com>
	<52A756AF.7000309@redhat.com> <52A75A29.1030204@redhat.com>
In-Reply-To: <52A75A29.1030204@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 4/5] monitor: add object-add (QMP) and
 object_add (HMP) command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: imammedo@redhat.com, akong@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com

于 2013/12/11 2:15, Paolo Bonzini 写道:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Il 10/12/2013 19:00, Eric Blake ha scritto:
>>>> +  'data': {'qom-type': 'str', 'id': 'str', '*props': 'dict'},
>>>> +  'gen': 'no' }
>>
>> This feels VERY open-coded.  No where else in qapi-schema do we
>> have 'dict' as a type
>
> Yes, in fact the "data" field is entirely skipped by the code
> generator (that's 'gen':'no').
>

Could we use hmp_object_add()->qmp_object_add()->object_add() code path,
instead of  hmp_object_add()->object_add(),qmp_object_add()->object_add()?
Would skipping by generator brings some difficult to it?