From: Fam Zheng <famz@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com,
imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 08/10] block: Add checks of blocker in block operations
Date: Fri, 13 Dec 2013 11:29:12 +0800 [thread overview]
Message-ID: <52AA7F08.2050203@redhat.com> (raw)
In-Reply-To: <87fvpy6umj.fsf@blackfin.pond.sub.org>
On 2013年12月12日 21:56, Markus Armbruster wrote:
> Fam Zheng <famz@redhat.com> writes:
>
>> Before operate on a BlockDriverState, respective types are checked
>> against bs->op_blockers and it will error out if there's a blocker.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> So this patch adds protection against "two of the same kind
> simultaneously". How could we check it's complete?
>
> Have we pondered the more general problem of which "operations"
> (whatever that is) exclude each other?
>
Good point. For what we want now, I think these extra checks are not
required. I think these could be added in a separate series if any.
Planning to drop it for next revision but the discussion is still open.
Thanks,
Fam
next prev parent reply other threads:[~2013-12-13 3:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 8:23 [Qemu-devel] [PATCH v7 00/10] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Fam Zheng
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 01/10] qapi: Add BlockOperationType enum Fam Zheng
2013-12-12 12:21 ` Kevin Wolf
2013-12-12 12:32 ` Fam Zheng
2013-12-12 12:49 ` Markus Armbruster
2013-12-12 12:53 ` Fam Zheng
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 02/10] block: Introduce op_blockers to BlockDriverState Fam Zheng
2013-12-12 12:50 ` Markus Armbruster
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 03/10] block: Parse "backing" option to reference existing BDS Fam Zheng
2013-12-12 12:52 ` Markus Armbruster
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 04/10] block: support dropping active in bdrv_drop_intermediate Fam Zheng
2013-12-12 13:24 ` Kevin Wolf
2013-12-13 3:30 ` Fam Zheng
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 05/10] stream: Use bdrv_drop_intermediate and drop close_unused_images Fam Zheng
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 06/10] block: Replace in_use with operation blocker Fam Zheng
2013-12-12 13:46 ` Markus Armbruster
2013-12-13 3:04 ` Fam Zheng
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 07/10] block: Pass error in bdrv_snapshot_create Fam Zheng
2013-12-12 13:52 ` Markus Armbruster
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 08/10] block: Add checks of blocker in block operations Fam Zheng
2013-12-12 13:56 ` Markus Armbruster
2013-12-13 3:29 ` Fam Zheng [this message]
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 09/10] qmp: add command 'blockdev-backup' Fam Zheng
2013-12-12 8:23 ` [Qemu-devel] [PATCH v7 10/10] block: Allow backup on referenced named BlockDriverState Fam Zheng
2013-12-13 2:40 ` [Qemu-devel] [PATCH v7 00/10] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Ian Main
2013-12-13 3:05 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AA7F08.2050203@redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=imain@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).