From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrT2V-0003VV-PA for qemu-devel@nongnu.org; Fri, 13 Dec 2013 08:44:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrT2P-00005u-1Y for qemu-devel@nongnu.org; Fri, 13 Dec 2013 08:44:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrT2O-00005k-PE for qemu-devel@nongnu.org; Fri, 13 Dec 2013 08:44:16 -0500 Message-ID: <52AB0F2C.5030703@redhat.com> Date: Fri, 13 Dec 2013 06:44:12 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386148259-10962-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1386148259-10962-5-git-send-email-xiawenc@linux.vnet.ibm.com> <529F939F.8020709@redhat.com> <52A017CD.2020508@linux.vnet.ibm.com> <52A53C49.4000601@linux.vnet.ibm.com> In-Reply-To: <52A53C49.4000601@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tTtqvl5MkWXPMvH4eaqnxAHvM3MtlghIx" Subject: Re: [Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tTtqvl5MkWXPMvH4eaqnxAHvM3MtlghIx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/08/2013 08:43 PM, Wenchao Xia wrote: >>> >>> convert -s snapshot.name=3Dname1 >>> >> Previous I planned to use -l for internal snapshot in all possible >> program, since -s is taken as external snapshot in qemu, qemu-nbd. Consistency in command line options between different tools is nice, but is less important than adding functionality. I'm perfectly fine if we use -l in one tool and -s in another, as long as the documentation is clear on how to spell the option for the tool I want to use. >> let -s stands for internal in qemu-img convert only, may bring >> confuse to user, so I deprecated it instead of enhance it(I want >> to remove it but may bring compatiablity issue). >> Yes, it should report error when both specified, will send a patch >> if you agree '-l' should still be used. >> >> > Eric, I hope to get your idea before patching, any comments? >=20 My biggest concern was that by adding -l as a superset of -s, but not taking care of the relation between the two, you created odd command line usage patterns. For qemu-img, it may be simpler to just make -s do everything, instead of trying to deprecate it (that is, adding -l for consistency with other tools while breaking -s isn't nice). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tTtqvl5MkWXPMvH4eaqnxAHvM3MtlghIx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSqw8tAAoJEKeha0olJ0NqCp8IAIS4weHD+Hm4GIm4zuQmSD3j j4sXggkiVZRk4yHIflGRV+CPXFrWJbwZIOZ4eP3QdBjq6SfqKnKdKrG29n1bHghh uqbtadNUqSTxViDKXLdPOKaksrY9vMKQnCUjK3Q7TejFnEad3R8gN5i3Nml22d7l BFBdf7QrIwTjDegs7rnfiHbEFw9/3a2wrnaTNWsftCDQToGJMdX1Aqzdu62OLmVr Lqcn0vu2ILRaqeTlQWF5Eo74FOaGSUrxcbTOvRsjsJ6LUls/FeL+6UDzMnpVHQlv X3sSSNlMHEDwvaeYdlUKoj5/t1mNGrLoH6TLOQPchJ2I6Hso8Fq1icjPYMaNK7A= =Ik6C -----END PGP SIGNATURE----- --tTtqvl5MkWXPMvH4eaqnxAHvM3MtlghIx--