From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrV8n-0000DE-Rz for qemu-devel@nongnu.org; Fri, 13 Dec 2013 10:59:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrV8g-0000uM-8o for qemu-devel@nongnu.org; Fri, 13 Dec 2013 10:59:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrV8f-0000uG-VT for qemu-devel@nongnu.org; Fri, 13 Dec 2013 10:58:54 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDFwrju015345 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 10:58:53 -0500 Message-ID: <52AB2EF2.9090702@redhat.com> Date: Fri, 13 Dec 2013 16:59:46 +0100 From: Max Reitz MIME-Version: 1.0 References: <1386785473-26157-1-git-send-email-mreitz@redhat.com> <1386785473-26157-22-git-send-email-mreitz@redhat.com> <52A992F2.6050906@redhat.com> In-Reply-To: <52A992F2.6050906@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 21/21] iotests: Test new blkdebug/blkverify interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 12.12.2013 11:41, Fam Zheng wrote: > On 2013=E5=B9=B412=E6=9C=8812=E6=97=A5 02:11, Max Reitz wrote: >> Add a test for the new blkdebug/blkverify interface. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/071 | 201=20 >> +++++++++++++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/071.out | 73 ++++++++++++++++ >> tests/qemu-iotests/group | 1 + >> 3 files changed, 275 insertions(+) >> create mode 100755 tests/qemu-iotests/071 >> create mode 100644 tests/qemu-iotests/071.out >> >> diff --git a/tests/qemu-iotests/071 b/tests/qemu-iotests/071 >> new file mode 100755 >> index 0000000..4be525e >> --- /dev/null >> +++ b/tests/qemu-iotests/071 >> @@ -0,0 +1,201 @@ >> +#!/bin/bash > > Is is intended to use hand coded json instead of iotests.py for QMP=20 > test here? I first tried to use Python, but I hit problems with=20 human-monitor-command and qemu-io. qemu-io prints errors to stderr,=20 therefore they are not returned via QMP. iotests.py discards stderr,=20 therefore there was no way to actually check for the qemu-io return statu= s. I could have added a function to iotests.py, but then I would have to=20 manually compare and filter the qemu-io output with a reference. All=20 these functions are already there for shell script tests. I guess I should add this explanation to the commit message, though=E2=80= =A6 Max