From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZr9-00087m-Ea for qemu-devel@nongnu.org; Fri, 13 Dec 2013 16:01:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrZr3-0002c3-2r for qemu-devel@nongnu.org; Fri, 13 Dec 2013 16:01:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZr2-0002bv-QK for qemu-devel@nongnu.org; Fri, 13 Dec 2013 16:01:01 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDL0vUi002277 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 16:00:57 -0500 Message-ID: <52AB7587.9070904@redhat.com> Date: Fri, 13 Dec 2013 14:00:55 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386954633-28905-1-git-send-email-mreitz@redhat.com> <1386954633-28905-20-git-send-email-mreitz@redhat.com> <20131213204958.GG3916@dhcp-200-207.str.redhat.com> In-Reply-To: <20131213204958.GG3916@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xAXXL2rX14cIVbx2gHFV4wOFCJq9KgpUI" Subject: Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Max Reitz Cc: Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xAXXL2rX14cIVbx2gHFV4wOFCJq9KgpUI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/13/2013 01:49 PM, Kevin Wolf wrote: > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: >> Introduce an alias "error" for "errno", since using the latter for QMP= >> is sure to result in various syntax errors due to the name being used >> directly as an identifier. >> >> Signed-off-by: Max Reitz >=20 > I can't say I like this, but it seems we don't have an option. Don't we already have a way to use QMP keys that collide with C keywords (for example, "unix" in qapi's SocketAddress becomes "q_unix" in C)? Why can't we reuse that mechanism, and just add "errno" to the polluted words list so that the generated C code uses "q_errno" rather than having to invent an "error" alias? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xAXXL2rX14cIVbx2gHFV4wOFCJq9KgpUI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSq3WHAAoJEKeha0olJ0NqADoH/itLkxKI+YRVgY6pmv/srfXI hJbRQL37fC+H/k1ZQ87R50U4s7PlPmSSZKx3Jg7J0wEPZqCqWU1sfrwHxCuDerOH 0XJB2B8K0qQXLYy8ihLRyOioPAOxh6dYL1IAn2kMdfNc3uRPomfjEpCjVb5s/Xe+ S8EbpmdU6OdKgGz5NQhO0h/lOUXCY3b/OIBVJsP2WtpHCxsgSo2SC9Z55OYIrok2 9dteMHxVxW4bOLq+ZzJDZedbn/V+sHF4afhA7dgj5D/zuZWJqObMefTeUnCPaSMe XY3HJ9Sb21/tmKazrwiacQhfYWFeew+5YvCIY49HofMWDUXTTjO8DoXv2Q1c11E= =a0kr -----END PGP SIGNATURE----- --xAXXL2rX14cIVbx2gHFV4wOFCJq9KgpUI--