From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZtI-0000fr-GC for qemu-devel@nongnu.org; Fri, 13 Dec 2013 16:03:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrZtD-0003I1-Jt for qemu-devel@nongnu.org; Fri, 13 Dec 2013 16:03:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZtD-0003Ht-Ax for qemu-devel@nongnu.org; Fri, 13 Dec 2013 16:03:15 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDL3Ekr031672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 16:03:14 -0500 Message-ID: <52AB7611.9050507@redhat.com> Date: Fri, 13 Dec 2013 14:03:13 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386954633-28905-1-git-send-email-mreitz@redhat.com> <1386954633-28905-21-git-send-email-mreitz@redhat.com> <20131213205434.GH3916@dhcp-200-207.str.redhat.com> In-Reply-To: <20131213205434.GH3916@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0P5Vhx292GgTQ4slfRG9Hf58qSMsMHkMv" Subject: Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Max Reitz Cc: Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0P5Vhx292GgTQ4slfRG9Hf58qSMsMHkMv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/13/2013 01:54 PM, Kevin Wolf wrote: > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: >> +# @BlkdebugInjectErrorOptions >> +# >> +# Describes a single error injection for blkdebug. >> +# >> +# @event: trigger event name >> +# >> +## >> +{ 'type': 'BlkdebugInjectErrorOptions', >> + 'data': { 'event': 'str', >=20 > I bet Eric will tell you that an enum for event would be much nicer. ;-= ) Am I that predictable? :) And see my comments on 19; I think with a minor tweak to qapi.py's polluted_words, that you could use @errno instead of @error. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0P5Vhx292GgTQ4slfRG9Hf58qSMsMHkMv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSq3YRAAoJEKeha0olJ0NqKTIH/2ZH5kSPcG9lVUEuxIja9Wit o5fIzh7yYMrRBk8Qdy9YaLoaNhMU/wG6+r2z7wPJg63YJZsWsC5EDyyJX6WcVcjg BMzogvK+fxIheDX8YKkt6s4qdLPfExLWCkO2ykkqztQ846Wgdl/PJP9SERUhdn3X Wn18zVv4tUADkeqAkonAVW0CP4KjOtYNIvdBZzAGtfEWoI/Yp59LXDC7zY1LZMUp XkqkI10jbrJpAqqIrqM6615T1aF8WK2cB4+ay4qY4gJYTaRXRBRffIyPtL3BdfOu RtFpSEKxpc/2Ji6hAey3Mqx87n7HrkOMtwzeJ+uuZyE+PU1MJX9P9GWHmLCGBSI= =AvKy -----END PGP SIGNATURE----- --0P5Vhx292GgTQ4slfRG9Hf58qSMsMHkMv--