From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrcUy-0006Xu-1p for qemu-devel@nongnu.org; Fri, 13 Dec 2013 18:50:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrcUt-0007xa-5r for qemu-devel@nongnu.org; Fri, 13 Dec 2013 18:50:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrcUs-0007xO-Uc for qemu-devel@nongnu.org; Fri, 13 Dec 2013 18:50:19 -0500 Message-ID: <52AB9D32.2090500@redhat.com> Date: Fri, 13 Dec 2013 16:50:10 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386740912-1655-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1386740912-1655-9-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1386740912-1655-9-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LKrUGVAAfX0VIqL7r9KjRsna1r9vxXkh3" Subject: Re: [Qemu-devel] [PATCH V4 8/9] qapi: convert BlockdevOptions to use enum discriminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LKrUGVAAfX0VIqL7r9KjRsna1r9vxXkh3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/10/2013 10:48 PM, Wenchao Xia wrote: > After this patch, hidden enum type BlockdevOptionsKind will not > be generated, and other API can use enum BlockdevDriver. >=20 > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > --- > qapi-schema.json | 14 +++++++++++++- > 1 files changed, 13 insertions(+), 1 deletions(-) You know, it might even be better if we just flat out require that ALL discriminated unions use an enum type, and discontinue support for open-coded string (with hidden enum generation). The extra type safety and potential for introspection that it buys us is worth the change. I don't know how much of your series that would affect, but it's food for thought. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LKrUGVAAfX0VIqL7r9KjRsna1r9vxXkh3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSq50zAAoJEKeha0olJ0NqD2YH+wb07VWboBsD51shcqi0Qda6 AKgPZ+oBInYFdxUfi9mkt2a0vk1j56ptc0aaRk21xrLspTg4+mYDCeQY5MLudItE p7fcAJ9NNMyC8MVQFEAGJ+X/D3nQRqM/DZ5FkMhlzeEC35uFTQsqtcFQ6rCH0KPQ 5DUHvWzpTTN21dpr4tsXCwEN8TS359QmID0kGCkOv6GqUXSe9OSHXkgdCN8iUMNH v1li25mGrjgjdegMyDrdi9oO6EFapm/lQM9TNsWA1lTb+caiDFKJPuYctzv7foON 3AivtK05EdWcMKoDts5dL1VbArtQTUBMSVSjiNLaMsOPy3oxpXyny7VKlqNpw50= =Cr1i -----END PGP SIGNATURE----- --LKrUGVAAfX0VIqL7r9KjRsna1r9vxXkh3--