From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48159)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VrcbU-0000cJ-3d
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 18:57:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VrcbO-00014d-0j
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 18:57:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9612)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VrcbN-00014Z-Os
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 18:57:01 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDNv0d4015853
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 13 Dec 2013 18:57:01 -0500
Message-ID: <52AB9EFD.7040605@redhat.com>
Date: Sat, 14 Dec 2013 00:57:49 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1386954633-28905-1-git-send-email-mreitz@redhat.com>
	<1386954633-28905-16-git-send-email-mreitz@redhat.com>
	<20131213203650.GC3916@dhcp-200-207.str.redhat.com>
In-Reply-To: <20131213203650.GC3916@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file
	configuration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 13.12.2013 21:36, Kevin Wolf wrote:
> Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
>> Introduce the "image" option as an alternative to specifying the image
>> through the filename.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
> One thing I'd like to see, either in the next version or in a follow-up
> series, is to generalise open_image() into a block.c function.

Yes, I thought of something like that myself. I think, eventually we 
need to merge bdrv_open() and bdrv_file_open() (now that "file"s can be 
nested and there may be block devices without "file"s, there is no 
actual need to separate both).

> The main difference between blkdebug and blkverify seems to be that
> blkverify does image format probing on its main image. This can be a
> bool argument to open_image().

I think, blkdebug should just force the raw driver with a common 
open_image().

Max