From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Vrcj9-0004cE-Ad
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 19:05:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Vrcj3-0003RT-Bb
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 19:05:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:16581)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Vrcj3-0003RP-3f
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 19:04:57 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBE04tk5023449
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 13 Dec 2013 19:04:55 -0500
Message-ID: <52ABA0D8.3040007@redhat.com>
Date: Sat, 14 Dec 2013 01:05:44 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1386954633-28905-1-git-send-email-mreitz@redhat.com>
	<1386954633-28905-6-git-send-email-mreitz@redhat.com>
	<20131213185803.GP3916@dhcp-200-207.str.redhat.com>
In-Reply-To: <20131213185803.GP3916@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from
	qdict_flatten_qdict()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 13.12.2013 19:58, Kevin Wolf wrote:
> Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
>> delete is always set to true, therefore it can be removed.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Nope, this can't be right.
>
> delete is always set, except for simple types in the top-level QDict.
> They get deleted now instead of being left alone.

Ah, I don't know how I missed the "if (prefix)"... Well then, I feared 
requiring delete would somehow require qdict_flatten_qlist() to have 
something similar, but if this can be wrong for top-level elements only, 
at least that won't be the case.

Max