From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrg3D-0008MT-Jg for qemu-devel@nongnu.org; Fri, 13 Dec 2013 22:38:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vrg38-0006on-OX for qemu-devel@nongnu.org; Fri, 13 Dec 2013 22:37:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrg38-0006oj-Fq for qemu-devel@nongnu.org; Fri, 13 Dec 2013 22:37:54 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBE3A8ON001238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 22:10:08 -0500 Message-ID: <52ABCC09.3070000@redhat.com> Date: Fri, 13 Dec 2013 20:10:01 -0700 From: Eric Blake MIME-Version: 1.0 References: <1385444708-19439-1-git-send-email-famz@redhat.com> <1385444708-19439-5-git-send-email-famz@redhat.com> In-Reply-To: <1385444708-19439-5-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="epIAQpnWMteCR7hEg15baBiIlsm75Q14u" Subject: Re: [Qemu-devel] [PATCH v6 4/6] commit: support commit active layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --epIAQpnWMteCR7hEg15baBiIlsm75Q14u Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/25/2013 10:45 PM, Fam Zheng wrote: > If active is top, it will be mirrored to base, (with block/mirror.c > code), then the image is switched when user completes the block job. >=20 > QMP documentation is updated. >=20 > Signed-off-by: Fam Zheng > --- > +++ b/qapi-schema.json > @@ -1967,9 +1967,11 @@ > # > # @top: The file name of the backing image within the ima= ge chain, > # which contains the topmost data to be committed d= own. > -# Note, the active layer as 'top' is currently unsu= pported. > # > # If top =3D=3D base, that is an error. > +# If top =3D=3D active, the job will not be complet= ed by itself, > +# user needs to complete the job with the block-job= -complete > +# command after getting the ready event. (Since 1.8= ) s/1.8/2.0/ What happens if the user does block-job-cancel instead of block-job-complete? With drive-mirror, that leaves the mirrored drive as a nice copy at the point in time of the cancel. I guess with commit, a cancel just aborts the commit and does not change which image is top. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --epIAQpnWMteCR7hEg15baBiIlsm75Q14u Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSq8wJAAoJEKeha0olJ0NqHisH/j+QeYOSI1nW06Q7NVh0HVJN INWICDOvbJ/0RhXHDiv2uAH27ITT89KjjjdJr2kOypUp3AiFNvtTsKjko/ZgfwVE yDM3pdH6ZiHjaoYe2l6SMzmXtAX0yoWx7SIfasU2VkTajX6ZjDyUpqXbSR6qgDeI rNJVJGHDmWGD4Q10K25mHVOiePDF0NJURKDTkqQZr8KrZi7OM6aNNTW3F07rqxaW Oh+uTRt058ixReOmLnA0kGQYQYeBnZ63kUrQWH0MBHckU+ABWKV+KMVSWZ9M+8fg abhJ7kF1MJYXHDv14QaSMUi8BT0UcPZCuAligwB/SJo6gFJ48AmldXEsyWQDvko= =acMo -----END PGP SIGNATURE----- --epIAQpnWMteCR7hEg15baBiIlsm75Q14u--