From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrgIp-0003Gk-Ev for qemu-devel@nongnu.org; Fri, 13 Dec 2013 22:54:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrgIk-0003dW-Te for qemu-devel@nongnu.org; Fri, 13 Dec 2013 22:54:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrgIk-0003ck-LU for qemu-devel@nongnu.org; Fri, 13 Dec 2013 22:54:02 -0500 Message-ID: <52ABD64C.6060507@redhat.com> Date: Fri, 13 Dec 2013 20:53:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386933277-20003-1-git-send-email-a.motakis@virtualopensystems.com> <1386933277-20003-2-git-send-email-a.motakis@virtualopensystems.com> In-Reply-To: <1386933277-20003-2-git-send-email-a.motakis@virtualopensystems.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OEAjFvmhnOxOAFepbgwWOh7np3aW1kuwo" Subject: Re: [Qemu-devel] [PATCH v3 1/7] Add -mem-share option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antonios Motakis , qemu-devel@nongnu.org, snabb-devel@googlegroups.com Cc: Peter Maydell , Anthony Liguori , Juan Quintela , Jan Kiszka , Michael Tokarev , Markus Armbruster , n.nikolaev@virtualopensystems.com, Orit Wasserman , Stefan Hajnoczi , lukego@gmail.com, Paolo Bonzini , tech@virtualopensystems.com, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OEAjFvmhnOxOAFepbgwWOh7np3aW1kuwo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/13/2013 04:14 AM, Antonios Motakis wrote: > This option complements -mem-path. It implies -mem-prealloc. If specifi= ed, > the guest RAM is allocated as a shared memory object. If both -mem-path= > and -mem-share are provided, the memory is allocated from the HugeTLBFS= > supplied path, and then mmapped with MAP_SHARED. >=20 > Signed-off-by: Antonios Motakis > Signed-off-by: Nikolay Nikolaev > --- > +++ b/qemu-options.hx > @@ -237,6 +237,15 @@ STEXI > Preallocate memory when using -mem-path. > ETEXI > =20 > +DEF("mem-share", 0, QEMU_OPTION_mem_share, Ouch. Doesn't this mean you are defining a boolean option (absent or present) as opposed to a qemuOpts option? I've already been complaining that other boolean opts are currently undiscoverable to QMP; they also have the drawback of having no way to turn the option back off if an alias turned it on earlier in the command line. Can we use qemuOpts here (so query-command-line-options can see it), and with a boolean on/off argument (so it's not a one-way switch)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OEAjFvmhnOxOAFepbgwWOh7np3aW1kuwo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSq9ZMAAoJEKeha0olJ0NqIxkIAI3bzZ045hL6sASTm8vBWoZP /rr9IMID/QfoCOPESFZrK+NX+HLqjb+EdqHkuDGu2cP8wengv63NvejbSDtcOh+S eRLc6nUMkpG8UE8c0pgDNWXmJIIt7J6HDa0xCi4EvawsuPjRdNXjaflTH4Ao7qa4 gJrgXrtKw2k1eyrBR4A76odjcAkUiaPf+nS2PHNgBr9E3Af1fLmNcL3Ti7UunRLi QZ800v0Mph9NfFmAgHR643apQJEIuTxTWDxE9TlVq3C99rqcQN2bg0yzHw6JV6lx 0YDowN4QuivCfrjWBoa5CH6JrKI4JYm8kAaP8P3LnWC9r3BwMVIYeOdFfVEBtf0= =SUDo -----END PGP SIGNATURE----- --OEAjFvmhnOxOAFepbgwWOh7np3aW1kuwo--