From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrn6i-0007A8-13 for qemu-devel@nongnu.org; Sat, 14 Dec 2013 06:10:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vrn6b-0002LX-Ic for qemu-devel@nongnu.org; Sat, 14 Dec 2013 06:10:03 -0500 Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]:34437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrn6b-0002LK-BN for qemu-devel@nongnu.org; Sat, 14 Dec 2013 06:09:57 -0500 Received: by mail-ea0-f182.google.com with SMTP id a15so1323060eae.13 for ; Sat, 14 Dec 2013 03:09:56 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52AC3C7E.1000006@redhat.com> Date: Sat, 14 Dec 2013 12:09:50 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1386933277-20003-1-git-send-email-a.motakis@virtualopensystems.com> <1386933277-20003-2-git-send-email-a.motakis@virtualopensystems.com> <52ABD64C.6060507@redhat.com> In-Reply-To: <52ABD64C.6060507@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [snabb-devel:650] Re: [PATCH v3 1/7] Add -mem-share option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: snabb-devel@googlegroups.com Cc: Peter Maydell , Anthony Liguori , Juan Quintela , Jan Kiszka , Michael Tokarev , qemu-devel@nongnu.org, n.nikolaev@virtualopensystems.com, Markus Armbruster , Orit Wasserman , Stefan Hajnoczi , lukego@gmail.com, Antonios Motakis , tech@virtualopensystems.com, =?UTF-8?B?QW5kcmVhcyBGw6Ry?= =?UTF-8?B?YmVy?= , Richard Henderson -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 14/12/2013 04:53, Eric Blake ha scritto: >>> +DEF("mem-share", 0, QEMU_OPTION_mem_share, > Ouch. Doesn't this mean you are defining a boolean option (absent > or present) as opposed to a qemuOpts option? I've already been > complaining that other boolean opts are currently undiscoverable to > QMP; they also have the drawback of having no way to turn the > option back off if an alias turned it on earlier in the command > line. Can we use qemuOpts here (so query-command-line-options can > see it), and with a boolean on/off argument (so it's not a one-way > switch)? This can be replaced with a memdev property as soon as memdev gets in. We'll need to provide a way to introspect the properties of a QOM object, though. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSrDx+AAoJEBvWZb6bTYbyf1oP/imUGPTzhoAOVb8MfR+2UnJ5 JQBQa6000nOLH54NnIPtTepJEQ+01sRCqJHykUEQD2q4WNL/ToBfu3FEwJbu7Wyx PHlt3BNG33LY+tM5pANgu/+Pliqe2dzPScTbfnkAawOUDSGFxkQWhJ/dFMHMfmiw HtrfmNF72liz9OJ8VEvt7JmQFW5lGeFpd3XzibDyC3VtjN7tX3KVe8lZ4oUjjNvD z2Q2pFs7fIHvKTTgMn1QQeKj42yXlzq+fNQPwuSlQQmlqqOjyDET9fCe2fYeqlGX b94iTzpqGNUwCRw2OluLftdNnScQKy2LEkokd5LAIqsyJEAVRZnAikLF2JyfdhTy lIGg9VX0VnqIVeauVOcpoBH1HqlDDMcen2DV5Sr5mTHrJ9m2EMm/aqVMYt/kPjP1 5IeYdJ44RxxAXr6aPnpK2/JjaJP+LfjB+xXUYqukjFOibDDXMr4wprKOgkDd5K/9 SkC8KSBsxK2pwUdztr4W1pSxnsYHwlsBKZM0i8MTZv5GsAe4oG3Authp5Uy15JmR xjmm6YfbRGRH/Ov+InlQ8BbzzCVRQkoaGb8B8GosKrDe+7Fnh+GUV2pjxvgySYk1 kUyo9RpeT9KebCpvg4RvasLX5A1yiDdh07KAp+Lyw1JXrw5zIeOPzf02LQJBtfmM 5MS3PXn4GbvmsgW/e1bA =Ed70 -----END PGP SIGNATURE-----