From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsFk7-0006Nw-Sa for qemu-devel@nongnu.org; Sun, 15 Dec 2013 12:44:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsFk1-0006Cl-NK for qemu-devel@nongnu.org; Sun, 15 Dec 2013 12:44:39 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51835 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsFk1-0006CX-Ge for qemu-devel@nongnu.org; Sun, 15 Dec 2013 12:44:33 -0500 Message-ID: <52ADEA79.3060802@suse.de> Date: Sun, 15 Dec 2013 18:44:25 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1386938688-22433-1-git-send-email-imammedo@redhat.com> <1386938688-22433-3-git-send-email-imammedo@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/11] qom: detect bad reentrance during object_class_foreach List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Igor Mammedov Cc: Kevin Wolf , Peter Maydell , Eduardo Habkost , marcel.a@redhat.com, "Michael S. Tsirkin" , "qemu-devel@nongnu.org Developers" , Don Koch , Blue Swirl , alex.williamson@redhat.com, Gerd Hoffmann , Anthony Liguori , Paolo Bonzini Am 14.12.2013 07:53, schrieb Peter Crosthwaite: > On Fri, Dec 13, 2013 at 10:44 PM, Igor Mammedov w= rote: >> From: Herv=E9 Poussineau >> >> We should not modify the type hash table while it is being iterated on= . >> Assert that it does not happen. >> >> Signed-off-by: Herv=E9 Poussineau >> Signed-off-by: Paolo Bonzini >> Signed-off-by: Igor Mammedov >> --- >> v2: >> * make ver more descriptinve s/enumerating/enumerating_classes/ >> [asked-by: Peter Crosthwaite] >> --- >> qom/object.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/qom/object.c b/qom/object.c >> index 3a43186..4a0fb86 100644 >> --- a/qom/object.c >> +++ b/qom/object.c >> @@ -78,8 +78,10 @@ static GHashTable *type_table_get(void) >> return type_table; >> } >> >> +static bool enumerating_classes =3D false; >=20 > This seems to be a change in terminology i.e. s/type/class. Should it > be enumerating_types or enumerating_type_table? Too many cooks... While offline, I picked up the original version, changing to enumerating_types, which Alexey also happened to choose, and then adopted his drop of "false" assignment. > Also blank line here between global var decl and fn. Same thought here, already did in my version. :) > Otherwise, >=20 > Reviewed-by: Peter Crosthwaite Thanks, will update while rebasing. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg