From: "Andreas Färber" <afaerber@suse.de>
To: Antony Pavlov <antonynpavlov@gmail.com>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Alex Dumitrache <broscutamaker@gmail.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Giovanni Condello <condellog@gmail.com>,
g3gg0 <georg.hofstetter@lx-networking.de>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 2/6] hw/arm/digic: prepare DIGIC-based boards support
Date: Mon, 16 Dec 2013 00:04:18 +0100 [thread overview]
Message-ID: <52AE3572.4030008@suse.de> (raw)
In-Reply-To: <1386970932-4886-3-git-send-email-antonynpavlov@gmail.com>
Hi,
Am 13.12.2013 22:42, schrieb Antony Pavlov:
> Also this patch adds initial support for Canon
> PowerShot A1100 IS compact camera.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> hw/arm/Makefile.objs | 1 +
> hw/arm/digic_boards.c | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 85 insertions(+)
> create mode 100644 hw/arm/digic_boards.c
This patch is lacking a one-line addition to tests/qom-test.c to have
this new board actually covered by `make check`. Please add it here if
you respin or post a separate patch as follow-up.
PMM/PC: May apply to other recent series as well, please keep eyes open!
Regards,
Andreas
P.S. It would've been helpful to include a diffstat in the cover letter
as is done by default for --cover-letter.
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-12-15 23:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 21:42 [Qemu-devel] [PATCH v8 0/6] hw/arm: add initial support for Canon DIGIC SoC Antony Pavlov
2013-12-13 21:42 ` [Qemu-devel] [PATCH v8 1/6] hw/arm: add very " Antony Pavlov
2013-12-13 21:42 ` [Qemu-devel] [PATCH v8 2/6] hw/arm/digic: prepare DIGIC-based boards support Antony Pavlov
2013-12-15 23:04 ` Andreas Färber [this message]
2013-12-16 6:47 ` Antony Pavlov
2013-12-13 21:42 ` [Qemu-devel] [PATCH v8 3/6] hw/arm/digic: add timer support Antony Pavlov
2013-12-14 6:41 ` Peter Crosthwaite
2013-12-15 22:24 ` Antony Pavlov
2013-12-13 21:42 ` [Qemu-devel] [PATCH v8 4/6] hw/arm/digic: add UART support Antony Pavlov
2013-12-13 21:42 ` [Qemu-devel] [PATCH v8 5/6] hw/arm/digic: add NOR ROM support Antony Pavlov
2013-12-13 21:42 ` [Qemu-devel] [PATCH v8 6/6] MAINTAINERS: Document 'Canon DIGIC' machine Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AE3572.4030008@suse.de \
--to=afaerber@suse.de \
--cc=antonynpavlov@gmail.com \
--cc=broscutamaker@gmail.com \
--cc=condellog@gmail.com \
--cc=georg.hofstetter@lx-networking.de \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).