From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsKjj-0002uA-6Z for qemu-devel@nongnu.org; Sun, 15 Dec 2013 18:04:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsKjX-0004qx-Ta for qemu-devel@nongnu.org; Sun, 15 Dec 2013 18:04:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54751 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsKjX-0004qr-NB for qemu-devel@nongnu.org; Sun, 15 Dec 2013 18:04:23 -0500 Message-ID: <52AE3572.4030008@suse.de> Date: Mon, 16 Dec 2013 00:04:18 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1386970932-4886-1-git-send-email-antonynpavlov@gmail.com> <1386970932-4886-3-git-send-email-antonynpavlov@gmail.com> In-Reply-To: <1386970932-4886-3-git-send-email-antonynpavlov@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v8 2/6] hw/arm/digic: prepare DIGIC-based boards support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antony Pavlov , qemu-devel@nongnu.org, Peter Maydell Cc: Alex Dumitrache , Peter Crosthwaite , Giovanni Condello , g3gg0 , Paolo Bonzini Hi, Am 13.12.2013 22:42, schrieb Antony Pavlov: > Also this patch adds initial support for Canon > PowerShot A1100 IS compact camera. >=20 > Signed-off-by: Antony Pavlov > --- > hw/arm/Makefile.objs | 1 + > hw/arm/digic_boards.c | 84 +++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 85 insertions(+) > create mode 100644 hw/arm/digic_boards.c This patch is lacking a one-line addition to tests/qom-test.c to have this new board actually covered by `make check`. Please add it here if you respin or post a separate patch as follow-up. PMM/PC: May apply to other recent series as well, please keep eyes open! Regards, Andreas P.S. It would've been helpful to include a diffstat in the cover letter as is done by default for --cover-letter. --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg