From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH V4 8/9] qapi: convert BlockdevOptions to use enum discriminator
Date: Mon, 16 Dec 2013 10:41:13 +0800 [thread overview]
Message-ID: <52AE6849.9080805@linux.vnet.ibm.com> (raw)
In-Reply-To: <52AB9D32.2090500@redhat.com>
于 2013/12/14 7:50, Eric Blake 写道:
> On 12/10/2013 10:48 PM, Wenchao Xia wrote:
>> After this patch, hidden enum type BlockdevOptionsKind will not
>> be generated, and other API can use enum BlockdevDriver.
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> ---
>> qapi-schema.json | 14 +++++++++++++-
>> 1 files changed, 13 insertions(+), 1 deletions(-)
>
> You know, it might even be better if we just flat out require that ALL
> discriminated unions use an enum type, and discontinue support for
> open-coded string (with hidden enum generation). The extra type safety
> and potential for introspection that it buys us is worth the change. I
> don't know how much of your series that would affect, but it's food for
> thought.
>
I thought that before, and it is not hard to do, just need
people's confirm that, string discriminator is not needed any more.
next prev parent reply other threads:[~2013-12-16 2:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 5:48 [Qemu-devel] [PATCH V4 0/9] qapi script: support enum as discriminator and better enum name Wenchao Xia
2013-12-11 5:48 ` [Qemu-devel] [PATCH V4 1/9] qapi script: remember enum values Wenchao Xia
2013-12-11 5:48 ` [Qemu-devel] [PATCH V4 2/9] qapi script: add check for duplicated key Wenchao Xia
2013-12-11 5:48 ` [Qemu-devel] [PATCH V4 3/9] qapi script: check correctness of discriminator values in union Wenchao Xia
2013-12-11 5:48 ` [Qemu-devel] [PATCH V4 4/9] qapi script: code move for generate_enum_name() Wenchao Xia
2013-12-11 5:48 ` [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to generate enum string Wenchao Xia
2013-12-12 4:26 ` Eric Blake
2013-12-11 5:48 ` [Qemu-devel] [PATCH V4 6/9] qapi script: support pre-defined enum type as discriminator in union Wenchao Xia
2013-12-13 14:10 ` Eric Blake
2013-12-11 5:48 ` [Qemu-devel] [PATCH V4 7/9] tests: add cases for inherited struct and union with discriminator Wenchao Xia
2013-12-13 23:47 ` Eric Blake
2013-12-11 5:48 ` [Qemu-devel] [PATCH V4 8/9] qapi: convert BlockdevOptions to use enum discriminator Wenchao Xia
2013-12-13 23:50 ` Eric Blake
2013-12-16 2:41 ` Wenchao Xia [this message]
2013-12-16 21:26 ` Luiz Capitulino
2013-12-11 5:48 ` [Qemu-devel] [PATCH V4 9/9] qapi script: do not add "_" for every capitalized char in enum Wenchao Xia
2013-12-13 23:50 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AE6849.9080805@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).