From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VsVO0-0007a6-2N
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 05:26:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VsVNs-0002lc-J7
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 05:26:51 -0500
Message-ID: <52AED555.1040105@redhat.com>
Date: Mon, 16 Dec 2013 11:26:29 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1387038700-9264-1-git-send-email-pl@kamp.de>
In-Reply-To: <1387038700-9264-1-git-send-email-pl@kamp.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block/iscsi: use a bh to schedule co
	reentrance
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, ronniesahlberg@gmail.com, anthony@codemonkey.ws

Il 14/12/2013 17:31, Peter Lieven ha scritto:
> this fixes a potential segfault and performance regression.
> 
> If the coroutine is reentered directly in the iscsi_co_generic_cb
> iscsi_process_{read,write} are interrupted and reentered any
> time later. One the one hand this could happen after an iscsi_close
> where the iscsi context is already gone (segfault). On the
> other hand this limits the number of processed callbacks
> in each aio_dispatch to one (potential performance regression).
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  block/iscsi.c |   11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/block/iscsi.c b/block/iscsi.c
> index fa69408..b0e6eea 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -68,6 +68,7 @@ typedef struct IscsiTask {
>      int do_retry;
>      struct scsi_task *task;
>      Coroutine *co;
> +    QEMUBH *bh;
>  } IscsiTask;
>  
>  typedef struct IscsiAIOCB {
> @@ -123,6 +124,13 @@ iscsi_schedule_bh(IscsiAIOCB *acb)
>      qemu_bh_schedule(acb->bh);
>  }
>  
> +static void iscsi_co_generic_bh_cb(void *opaque)
> +{
> +    struct IscsiTask *iTask = opaque;
> +    qemu_bh_delete(iTask->bh);
> +    qemu_coroutine_enter(iTask->co, NULL);
> +}
> +
>  static void
>  iscsi_co_generic_cb(struct iscsi_context *iscsi, int status,
>                          void *command_data, void *opaque)
> @@ -147,7 +155,8 @@ iscsi_co_generic_cb(struct iscsi_context *iscsi, int status,
>  
>  out:
>      if (iTask->co) {
> -        qemu_coroutine_enter(iTask->co, NULL);
> +        iTask->bh = qemu_bh_new(iscsi_co_generic_bh_cb, iTask);
> +        qemu_bh_schedule(iTask->bh);
>      }
>  }
>  
> 

Applied to scsi-next branch, thanks.

Paolo