From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsXgk-0005gC-Bp for qemu-devel@nongnu.org; Mon, 16 Dec 2013 07:54:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsXge-0003dN-2E for qemu-devel@nongnu.org; Mon, 16 Dec 2013 07:54:22 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38457 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsXgd-0003dH-Rx for qemu-devel@nongnu.org; Mon, 16 Dec 2013 07:54:15 -0500 Message-ID: <52AEF7F3.2020504@suse.de> Date: Mon, 16 Dec 2013 13:54:11 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1387181170-23267-1-git-send-email-edgar.iglesias@gmail.com> <1387181170-23267-11-git-send-email-edgar.iglesias@gmail.com> In-Reply-To: <1387181170-23267-11-git-send-email-edgar.iglesias@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v1 10/22] exec: On AS changes, only flush affected CPU TLBs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: edgar.iglesias@gmail.com, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, blauwirbel@gmail.com, aliguori@amazon.com, pcrost@xilinx.com, pbonzini@redhat.com, aurelien@aurel32.net, rth@twiddle.net Am 16.12.2013 09:05, schrieb edgar.iglesias@gmail.com: > From: "Edgar E. Iglesias" >=20 > Signed-off-by: Edgar E. Iglesias > --- > exec.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/exec.c b/exec.c > index edb6a43..203c8e4 100644 > --- a/exec.c > +++ b/exec.c > @@ -1810,6 +1810,11 @@ static void tcg_commit(MemoryListener *listener) > reset the modified entries */ > /* XXX: slow ! */ > CPU_FOREACH(cpu) { > + /* FIXME: Disentangle the cpu.h circular files deps so we can > + directly get the right CPU from listener. */ Was this circular dependency explained somewhere? > + if (cpu->tcg_as_listener !=3D listener) { > + continue; > + } If this is to be committed (rather than fixed in a v2), please move to below variables as usual. Regards, Andreas > CPUArchState *env =3D cpu->env_ptr; > =20 > tlb_flush(env, 1); --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg