From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vsa4C-0002PF-GY for qemu-devel@nongnu.org; Mon, 16 Dec 2013 10:26:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vsa46-00006C-L1 for qemu-devel@nongnu.org; Mon, 16 Dec 2013 10:26:44 -0500 Message-ID: <52AF1BAB.3080808@gmail.com> Date: Mon, 16 Dec 2013 09:26:35 -0600 From: Tom Musta MIME-Version: 1.0 References: <1386604035-2507-1-git-send-email-tommusta@gmail.com> <1386604035-2507-10-git-send-email-tommusta@gmail.com> <52AF1A3B.4060806@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Small Negatives in float64_to_uint64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "qemu-ppc@nongnu.org" , QEMU Developers On 12/16/2013 9:24 AM, Peter Maydell wrote: > On 16 December 2013 15:20, Tom Musta wrote: >> On 12/12/2013 6:13 PM, Peter Maydell wrote: >>> This function isn't in the copy of fpu/softfloat.c that's in master, >>> unless I'm confused. Does this series depend on something else? > > >> Peter: Yes, it does. See >> http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg00045.html >> and specifically patch 1/19. > > OK. Please could you fold this bugfix directly into that patch? > It's very hard to review "this is broken and then this thing > fixes it", especially if the two patches are in different > series -- much easier to just have one patch which implements > the fixed version. > > thanks > -- PMM > Yes, I will do that. Thanks, Peter.