From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsrgH-00057k-5i for qemu-devel@nongnu.org; Tue, 17 Dec 2013 05:15:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsrgB-0007wD-Nv for qemu-devel@nongnu.org; Tue, 17 Dec 2013 05:15:13 -0500 Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:37644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsrgB-0007vf-GH for qemu-devel@nongnu.org; Tue, 17 Dec 2013 05:15:07 -0500 Received: by mail-ee0-f44.google.com with SMTP id b57so2757908eek.17 for ; Tue, 17 Dec 2013 02:15:06 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52B02428.20306@redhat.com> Date: Tue, 17 Dec 2013 11:15:04 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20131217085540.GA7891@mail.duskware.de> In-Reply-To: <20131217085540.GA7891@mail.duskware.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] qemu 1.7.0 does not build on NetBSD (patch) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Martin Husemann Cc: qemu-devel@nongnu.org Il 17/12/2013 09:55, Martin Husemann ha scritto: > On NetBSD int8_t and friends are preprocessor macros expanding to __int8_t > (which is a typedef provided by machine dependent headers). > > include/exec/softmmu_template.h tries to safe 3 lines of code by using > preprosseor concatenation, which only will work if int8_t is not a define, > or defined to int8_t. > > The attached patch fixes this. Hi Martin, the patch looks good, but please resend it according to the rules in http://wiki.qemu.org/Contribute/SubmitAPatch - thanks! Paolo