From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vsv8j-0000Z6-Oe for qemu-devel@nongnu.org; Tue, 17 Dec 2013 08:56:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vsv8e-0007oo-SC for qemu-devel@nongnu.org; Tue, 17 Dec 2013 08:56:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vsv8e-0007oj-In for qemu-devel@nongnu.org; Tue, 17 Dec 2013 08:56:44 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBHDuhSw015574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Dec 2013 08:56:43 -0500 Message-ID: <52B05819.8040708@redhat.com> Date: Tue, 17 Dec 2013 06:56:41 -0700 From: Eric Blake MIME-Version: 1.0 References: <184d3b68e1da2f5b0dd80e06416836286e3f840f.1387276279.git.jcody@redhat.com> In-Reply-To: <184d3b68e1da2f5b0dd80e06416836286e3f840f.1387276279.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3fV0JROpvxm4MU3U2OjSWWevlUD3RFi4M" Subject: Re: [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, and .bdrv_check implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3fV0JROpvxm4MU3U2OjSWWevlUD3RFi4M Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/17/2013 03:33 AM, Jeff Cody wrote: > If there is a dirty log file to be replayed in a VHDX image, it is > replayed in .vhdx_open(). However, if the file is opened read-only, > then a somewhat cryptic error message results. >=20 > This adds a more helpful error message for the user. If an image file > contains a log to be replayed, and is opened read-only, the user is > instructed to run 'qemu-img check -r all' on the image file. >=20 > Running qemu-img check -r all will cause the image file to be opened > r/w, which will replay the log file. If a log file replay is detected,= > this is flagged, and bdrv_check will increase the corruptions_fixed > count for the image. > + error_setg_errno(errp, EPERM, > + "VHDX image file '%s' opened read-only, b= ut " > + "contains a log that needs replayed. To = replay " s/replayed/replaying/ > + "the log, execute:\n qemu-img check -r al= l '%s'", > + bs->filename, bs->filename); > + goto exit; --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3fV0JROpvxm4MU3U2OjSWWevlUD3RFi4M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSsFgaAAoJEKeha0olJ0Nqjd0H/0xyj31palGNTd63PP2bOpSi 7nHzRM7vT1xjajdy0558ZiTu95FAEk3uh8DYhFqkCo2BwqltvStYpyckvxPQBpyf 1JFKaUAH2vAtJsWcwcqrPLWpYNCG6BNcM9pLmZZ0MVcpUks/Wmh23S0ZH/9+RLPm Gql4EftnEatMxVQmiRN6nzys11OMT3iNCkF4jwxnri/XXY8HDXiUL2g0eLpYyp7E mf8xEdEmBk+kwaJ9gFiJrckJ396Vsq9Esn8SlWtQuY5fgOf7wob/+TT0J2XvHqtn DHif+rC0luhzcdeels4y2sI8plxLVG9Iuyuxnroq4uDQQd4FzQIHQTD+zVGs6Mc= =YlLp -----END PGP SIGNATURE----- --3fV0JROpvxm4MU3U2OjSWWevlUD3RFi4M--