From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsxDJ-0002Wm-0G for qemu-devel@nongnu.org; Tue, 17 Dec 2013 11:09:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsxDA-0007jc-T3 for qemu-devel@nongnu.org; Tue, 17 Dec 2013 11:09:40 -0500 Received: from e33.co.us.ibm.com ([32.97.110.151]:48471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsxDA-0007jY-My for qemu-devel@nongnu.org; Tue, 17 Dec 2013 11:09:32 -0500 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Dec 2013 09:09:32 -0700 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 04A131FF001A for ; Tue, 17 Dec 2013 09:09:05 -0700 (MST) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08026.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rBHG9RdC5439890 for ; Tue, 17 Dec 2013 17:09:27 +0100 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rBHG9Rxo017598 for ; Tue, 17 Dec 2013 09:09:27 -0700 Message-ID: <52B07736.4070406@linux.vnet.ibm.com> Date: Tue, 17 Dec 2013 11:09:26 -0500 From: Matthew Rosato MIME-Version: 1.0 References: <1387227072-21965-1-git-send-email-mjrosato@linux.vnet.ibm.com> <1387227072-21965-6-git-send-email-mjrosato@linux.vnet.ibm.com> <66752973-0E0C-4D70-9470-72EE48BD0642@suse.de> <0635E44F-AAAC-4059-813B-20DD5141369F@suse.de> In-Reply-To: <0635E44F-AAAC-4059-813B-20DD5141369F@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] sclp-s390: Add memory hotplug SCLPs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Gleb Natapov , QEMU Developers , Christian Borntraeger , aliguori@amazon.com, Cornelia Huck , Paolo Bonzini , Richard Henderson On 12/16/2013 06:18 PM, Alexander Graf wrote: > > On 16.12.2013, at 22:42, Alexander Graf wrote: > >> >> On 16.12.2013, at 21:51, Matthew Rosato wrote: >> > > [...] > >> >>> + } >>> + } >>> + } >>> + sccb->h.response_code = cpu_to_be16(SCLP_RC_NORMAL_COMPLETION); >>> +} >>> + >>> static void sclp_execute(SCCB *sccb, uint64_t code) >>> { >>> S390SCLPDevice *sdev = get_event_facility(); >>> @@ -50,6 +255,22 @@ static void sclp_execute(SCCB *sccb, uint64_t code) >>> case SCLP_CMDW_READ_SCP_INFO_FORCED: >>> read_SCP_info(sccb); >>> break; >>> + case SCLP_READ_STORAGE_ELEMENT_INFO: >>> + if (code & 0xff00) { >>> + read_storage_element1_info(sccb); >>> + } else { >>> + read_storage_element0_info(sccb); >>> + } >>> + break; >>> + case SCLP_ATTACH_STORAGE_ELEMENT: >>> + attach_storage_element(sccb, (code & 0xff00) >> 8); >>> + break; >>> + case SCLP_ASSIGN_STORAGE: >>> + assign_storage(sccb); >>> + break; >>> + case SCLP_UNASSIGN_STORAGE: >>> + unassign_storage(sccb); >>> + break; >> >> Do you think it'd be possible to model this whole thing as a device that has its own state? That's where you could keep the bitmap for example. You'd only need some callback mechanism to hook into the SCLP calls, but the PPC guys already have something similar with their hypercalls. > > Speaking of state - in the current model the "is standby storage active" bitmap doesn't get migrated, no? > Yes, you are correct, migration support still needs to be added - But I wanted to get this much out for review at least. > > Alex > > >