From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vsz1V-0005vj-6x for qemu-devel@nongnu.org; Tue, 17 Dec 2013 13:05:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vsz1Q-00041F-Gu for qemu-devel@nongnu.org; Tue, 17 Dec 2013 13:05:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vsz1Q-000418-5X for qemu-devel@nongnu.org; Tue, 17 Dec 2013 13:05:32 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBHI5UtJ007363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Dec 2013 13:05:30 -0500 Message-ID: <52B09268.6000400@redhat.com> Date: Tue, 17 Dec 2013 11:05:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-2-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-2-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tJ32pqrRfhtJmwXgEn6PbBA4xRSQFV2Lb" Subject: Re: [Qemu-devel] [PATCH 01/38] bitmap: use long as index List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tJ32pqrRfhtJmwXgEn6PbBA4xRSQFV2Lb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/17/2013 08:25 AM, Juan Quintela wrote: > Move index and size fields from int to long. We need that for > migration. long is 64 bits on sane architectures, and 32bits should > be enough on all the 32bits architectures. >=20 > Signed-off-by: Juan Quintela > --- > include/qemu/bitmap.h | 77 ++++++++++++++++++++++++++-----------------= -------- > include/qemu/bitops.h | 14 +++++----- > util/bitmap.c | 60 +++++++++++++++++++-------------------- > 3 files changed, 76 insertions(+), 75 deletions(-) >=20 > diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h > index 308bbb7..afdd257 100644 > --- a/include/qemu/bitmap.h > +++ b/include/qemu/bitmap.h > @@ -31,7 +31,7 @@ > * bitmap_andnot(dst, src1, src2, nbits) *dst =3D *src1 & ~(*src2) > * bitmap_complement(dst, src, nbits) *dst =3D ~(*src) > * bitmap_equal(src1, src2, nbits) Are *src1 and *src2 equal? > - * bitmap_intersects(src1, src2, nbits) Do *src1 and *src2 overlap? > + * bitmap_intersects(src1, src2, nbits) Do *src1 and *src2 ove= rlap? Spurious whitespace change? > * bitmap_empty(src, nbits) Are all bits zero in *src? > * bitmap_full(src, nbits) Are all bits set in *src? > * bitmap_set(dst, pos, nbits) Set specified bit area > @@ -62,71 +62,71 @@ > ) >=20 > #define DECLARE_BITMAP(name,bits) \ > - unsigned long name[BITS_TO_LONGS(bits)] > + unsigned long name[BITS_TO_LONGS(bits)] >=20 > #define small_nbits(nbits) \ > - ((nbits) <=3D BITS_PER_LONG) > + ((nbits) <=3D BITS_PER_LONG) Whitespace change, but in same hunk as real changes, so ok for checkpatch.pl reasons. > +++ b/include/qemu/bitops.h > @@ -28,7 +28,7 @@ > * @nr: the bit to set > * @addr: the address to start counting from > */ > -static inline void set_bit(int nr, unsigned long *addr) > +static inline void set_bit(long nr, unsigned long *addr) > { > unsigned long mask =3D BIT_MASK(nr); > unsigned long *p =3D addr + BIT_WORD(nr); Worth cleaning up this whitespace while in the area? Content changes seem sane to me: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tJ32pqrRfhtJmwXgEn6PbBA4xRSQFV2Lb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSsJJoAAoJEKeha0olJ0NqBtYH/3Yy9pVTnOdKWJXnbu/HWcX8 6AVQezh8RYlFMT37YvR3JWYo0lvMWo5hK1FXCGiex0HNyxqNWLg9opiUXGhbvgGe 3/08m1NF9aDeRReZxm7vJ0T060/T5pfFuZgbBgYniJNlghuwP7h08mBM2p60lhKt mAx2gDhmAFPL6F9FkRnkyYi77HM269/f+KhXxNch/TtN4qUrzV+a2nils4XfmIoR ech01C1b7Ancw1OQpNNtpoB2T1j8Ggj5fqsw1pbGocnmVruLBX1rWjGb8LoM957F SCGcVcNq2ZZCpQNAXQgYo35Mu6KCOtwCsWYnz/5aD6he1R17gpE3KEwJxxO89SE= =XWpK -----END PGP SIGNATURE----- --tJ32pqrRfhtJmwXgEn6PbBA4xRSQFV2Lb--