From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vt0Np-0007zx-Vl for qemu-devel@nongnu.org; Tue, 17 Dec 2013 14:32:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vt0Nk-0004W6-Ur for qemu-devel@nongnu.org; Tue, 17 Dec 2013 14:32:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vt0Nk-0004U5-Mm for qemu-devel@nongnu.org; Tue, 17 Dec 2013 14:32:40 -0500 Message-ID: <52B0A6D3.4030408@redhat.com> Date: Tue, 17 Dec 2013 20:32:35 +0100 From: Laszlo Ersek MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] converting pci-assign to qerror_report()? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "qemu-devel@nongnu.org" , Markus Armbruster Hi Anthony, I'm thinking about converting the error reporting in assigned_initfn() [hw/i386/kvm/pci-assign.c] from error_report() to qerror_report[_err](). Internally I might use error propagation, but I don't intend to convert pci-assign from qdev to QOM / true realizefn. (I intend to *re*-try error propagation up to and thru device_add even less.) So internal errors wouldn't propagate out of assigned_initfn(), I'd probably consume them there with qerror_report_err(). Considering your earlier message https://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg03102.html will you NAK such a patch? (I'll note that this is not a *new* QMP function.) Thanks! Laszlo