From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtE4D-0006Tp-9O for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:09:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtE47-0004Wp-9y for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:09:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtE47-0004Wj-1p for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:09:19 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIA9IHG022046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 05:09:18 -0500 Message-ID: <52B1746F.8020003@redhat.com> Date: Wed, 18 Dec 2013 12:09:51 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-9-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-9-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/38] memory: all users of cpu_physical_memory_get_dirty used only one flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:25 PM, Juan Quintela wrote: > So cpu_physical_memory_get_dirty_flags is not needed anymore > > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > include/exec/memory-internal.h | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index 0b25c3f..53cfe83 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -44,11 +44,6 @@ void qemu_ram_free_from_ptr(ram_addr_t addr); > #define CODE_DIRTY_FLAG 0x02 > #define MIGRATION_DIRTY_FLAG 0x08 > > -static inline int cpu_physical_memory_get_dirty_flags(ram_addr_t addr) > -{ > - return ram_list.phys_dirty[addr >> TARGET_PAGE_BITS]; > -} > - > static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, > int dirty_flag) > { > @@ -67,7 +62,7 @@ static inline bool cpu_physical_memory_is_dirty(ram_addr_t addr) > > static inline int cpu_physical_memory_get_dirty(ram_addr_t start, > ram_addr_t length, > - int dirty_flags) > + int dirty_flag) > { > int ret = 0; > ram_addr_t addr, end; > @@ -75,7 +70,7 @@ static inline int cpu_physical_memory_get_dirty(ram_addr_t start, > end = TARGET_PAGE_ALIGN(start + length); > start &= TARGET_PAGE_MASK; > for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { > - ret |= cpu_physical_memory_get_dirty_flags(addr) & dirty_flags; > + ret |= cpu_physical_memory_get_dirty_flag(addr, dirty_flag); > } > return ret; > } > Reviewed-by: Orit Wasserman