From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1VtE9e-0002Uw-4H
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:15:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1VtE9Y-0006E0-5m
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:15:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44248)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1VtE9X-0006Dv-Ti
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:14:56 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIAEtMD023542
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 18 Dec 2013 05:14:55 -0500
Message-ID: <52B175C0.7000805@redhat.com>
Date: Wed, 18 Dec 2013 12:15:28 +0200
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1387293974-24718-1-git-send-email-quintela@redhat.com>
	<1387293974-24718-13-git-send-email-quintela@redhat.com>
In-Reply-To: <1387293974-24718-13-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 12/38] memory: use bit 2 for migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org

On 12/17/2013 05:25 PM, Juan Quintela wrote:
> For historical reasons it was bit 3.  Once there, create a constant to
> know the number of clients.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>   include/exec/memory.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index b8e76f4..d5e9d58 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -35,7 +35,8 @@ typedef struct MemoryRegionMmio MemoryRegionMmio;
>
>   #define DIRTY_MEMORY_VGA       0
>   #define DIRTY_MEMORY_CODE      1
> -#define DIRTY_MEMORY_MIGRATION 3
> +#define DIRTY_MEMORY_MIGRATION 2
> +#define DIRTY_MEMORY_NUM       3        /* num of dirty bits */
>
>   struct MemoryRegionMmio {
>       CPUReadMemoryFunc *read[3];
>

Reviewed-by: Orit Wasserman <owasserm@redhat.com>