From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEBK-0004WY-2J for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:16:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtEBC-0006nk-PQ for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:16:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEBC-0006nY-Gu for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:16:38 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIAGbFx025375 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 05:16:38 -0500 Message-ID: <52B17627.5050506@redhat.com> Date: Wed, 18 Dec 2013 12:17:11 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-15-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-15-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/38] memory: only resize dirty bitmap when memory size increases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:25 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > exec.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/exec.c b/exec.c > index 9996da2..bed5c07 100644 > --- a/exec.c > +++ b/exec.c > @@ -1210,6 +1210,9 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host, > MemoryRegion *mr) > { > RAMBlock *block, *new_block; > + ram_addr_t old_ram_size, new_ram_size; > + > + old_ram_size = last_ram_offset() >> TARGET_PAGE_BITS; > > size = TARGET_PAGE_ALIGN(size); > new_block = g_malloc0(sizeof(*new_block)); > @@ -1270,10 +1273,13 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host, > ram_list.version++; > qemu_mutex_unlock_ramlist(); > > - ram_list.phys_dirty = g_realloc(ram_list.phys_dirty, > - last_ram_offset() >> TARGET_PAGE_BITS); > - memset(ram_list.phys_dirty + (new_block->offset >> TARGET_PAGE_BITS), > + new_ram_size = last_ram_offset() >> TARGET_PAGE_BITS; > + > + if (new_ram_size > old_ram_size) { > + ram_list.phys_dirty = g_realloc(ram_list.phys_dirty, new_ram_size); > + memset(ram_list.phys_dirty + (new_block->offset >> TARGET_PAGE_BITS), > 0, size >> TARGET_PAGE_BITS); > + } > cpu_physical_memory_set_dirty_range(new_block->offset, size); > > qemu_ram_setup_dump(new_block->host, size); > Reviewed-by: Orit Wasserman