From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEBk-0005B1-Ty for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:17:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtEBe-00070F-Uh for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:17:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEBe-000702-Ly for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:17:06 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIAH4hN024913 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 05:17:05 -0500 Message-ID: <52B17642.30705@redhat.com> Date: Wed, 18 Dec 2013 12:17:38 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-16-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-16-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 15/38] memory: cpu_physical_memory_clear_dirty_flag() result is never used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:25 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > include/exec/memory-internal.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index d09d6d8..666490c 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -86,14 +86,14 @@ static inline void cpu_physical_memory_set_dirty(ram_addr_t addr) > cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_CODE); > } > > -static inline int cpu_physical_memory_clear_dirty_flag(ram_addr_t addr, > +static inline void cpu_physical_memory_clear_dirty_flag(ram_addr_t addr, > unsigned client) > { > int mask = ~(1 << client); > > assert(client < DIRTY_MEMORY_NUM); > > - return ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] &= mask; > + ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] &= mask; > } > > static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, > Reviewed-by: Orit Wasserman