From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEMc-0004ic-A9 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:28:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtEMW-0001si-7O for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:28:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEMV-0001rd-MP for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:28:19 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIASJ5J023150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 05:28:19 -0500 Message-ID: <52B178E3.7060701@redhat.com> Date: Wed, 18 Dec 2013 12:28:51 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-20-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-20-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 19/38] memory: unfold cpu_physical_memory_set_dirty() in its only user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:25 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > include/exec/memory-internal.h | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index 2f6610a..9d34434 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -79,13 +79,6 @@ static inline void cpu_physical_memory_set_dirty_flag(ram_addr_t addr, > set_bit(addr >> TARGET_PAGE_BITS, ram_list.dirty_memory[client]); > } > > -static inline void cpu_physical_memory_set_dirty(ram_addr_t addr) > -{ > - cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_MIGRATION); > - cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_VGA); > - cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_CODE); > -} > - > static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, > ram_addr_t length) > { > @@ -94,7 +87,9 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, > end = TARGET_PAGE_ALIGN(start + length); > start &= TARGET_PAGE_MASK; > for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { > - cpu_physical_memory_set_dirty(addr); > + cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_MIGRATION); > + cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_VGA); > + cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_CODE); > } > xen_modified_memory(addr, length); > } > Reviewed-by: Orit Wasserman