From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEN7-0005FX-9v for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:29:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtEN1-00024c-B6 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:28:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEN1-00024V-2G for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:28:51 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIASorW023281 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 05:28:50 -0500 Message-ID: <52B17903.9010702@redhat.com> Date: Wed, 18 Dec 2013 12:29:23 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-21-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-21-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 20/38] memory: unfold cpu_physical_memory_set_dirty_flag() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:25 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > include/exec/memory-internal.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index 9d34434..b99617a 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -87,9 +87,12 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, > end = TARGET_PAGE_ALIGN(start + length); > start &= TARGET_PAGE_MASK; > for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { > - cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_MIGRATION); > - cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_VGA); > - cpu_physical_memory_set_dirty_flag(addr, DIRTY_MEMORY_CODE); > + set_bit(addr >> TARGET_PAGE_BITS, > + ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION]); > + set_bit(addr >> TARGET_PAGE_BITS, > + ram_list.dirty_memory[DIRTY_MEMORY_VGA]); > + set_bit(addr >> TARGET_PAGE_BITS, > + ram_list.dirty_memory[DIRTY_MEMORY_CODE]); > } > xen_modified_memory(addr, length); > } > Reviewed-by: Orit Wasserman