From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtER0-0008IA-Pz for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:33:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtEQu-0003Sc-Qj for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:32:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEQu-0003ST-Hh for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:32:52 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIAWpl8024876 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 05:32:51 -0500 Message-ID: <52B179F4.1070708@redhat.com> Date: Wed, 18 Dec 2013 12:33:24 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-23-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-23-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 22/38] memory: cpu_physical_memory_get_dirty() is used as returning a bool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:25 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > include/exec/memory-internal.h | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index edca8a8..fa28fc6 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -40,11 +40,10 @@ void *qemu_get_ram_ptr(ram_addr_t addr); > void qemu_ram_free(ram_addr_t addr); > void qemu_ram_free_from_ptr(ram_addr_t addr); > > -static inline int cpu_physical_memory_get_dirty(ram_addr_t start, > - ram_addr_t length, > - unsigned client) > +static inline bool cpu_physical_memory_get_dirty(ram_addr_t start, > + ram_addr_t length, > + unsigned client) > { > - int ret = 0; > ram_addr_t addr, end; > > assert(client < DIRTY_MEMORY_NUM); > @@ -52,10 +51,12 @@ static inline int cpu_physical_memory_get_dirty(ram_addr_t start, > end = TARGET_PAGE_ALIGN(start + length); > start &= TARGET_PAGE_MASK; > for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { > - ret |= test_bit(addr >> TARGET_PAGE_BITS, > - ram_list.dirty_memory[client]); > + if (test_bit(addr >> TARGET_PAGE_BITS, > + ram_list.dirty_memory[client])) { > + return true; > + } > } > - return ret; > + return false; > } > > static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, > Reviewed-by: Orit Wasserman