From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEWB-0003DQ-75 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:38:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtEW5-0004yu-7X for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:38:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtEW4-0004yg-NR for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:38:13 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIAcAdl000372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 05:38:11 -0500 Message-ID: <52B17B34.2030407@redhat.com> Date: Wed, 18 Dec 2013 12:38:44 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-24-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-24-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 23/38] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:25 PM, Juan Quintela wrote: > Now all functions use the same wording that bitops/bitmap operations > > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > exec.c | 2 +- > include/exec/memory-internal.h | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/exec.c b/exec.c > index ad9866c..6bef3e5 100644 > --- a/exec.c > +++ b/exec.c > @@ -747,7 +747,7 @@ void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t end, > length = end - start; > if (length == 0) > return; > - cpu_physical_memory_mask_dirty_range(start, length, client); > + cpu_physical_memory_clear_dirty_range(start, length, client); > > if (tcg_enabled()) { > tlb_reset_dirty_range_all(start, end, length); > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index fa28fc6..c04a92a 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -100,9 +100,9 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, > xen_modified_memory(addr, length); > } > > -static inline void cpu_physical_memory_mask_dirty_range(ram_addr_t start, > - ram_addr_t length, > - unsigned client) > +static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start, > + ram_addr_t length, > + unsigned client) > { > ram_addr_t addr, end; > Reviewed-by: Orit Wasserman