From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33367)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VtEY2-0005Zd-4E
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:40:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VtEXt-0005W6-JZ
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:40:14 -0500
Received: from mail-qa0-x231.google.com ([2607:f8b0:400d:c00::231]:50534)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VtEXt-0005QI-6L
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 05:40:05 -0500
Received: by mail-qa0-f49.google.com with SMTP id ii20so257506qab.8
	for <qemu-devel@nongnu.org>; Wed, 18 Dec 2013 02:40:04 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52B17B7C.5090702@redhat.com>
Date: Wed, 18 Dec 2013 11:39:56 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1386182548-27119-1-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1386182548-27119-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [qemu-kvm RHEL7 PATCH] Add support statement to
	-help output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, Miroslav Rezanina <mrezanin@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

Il 04/12/2013 19:42, Eduardo Habkost ha scritto:
> Bugzilla: 972773
> Brew scratch build: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6676272
> 
> Add support statement to -help output, reporting direct qemu-kvm usage
> as unsupported by Red Hat, and advising users to use libvirt instead.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  vl.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/vl.c b/vl.c
> index 9b1738b..fdc8c65 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1995,9 +1995,17 @@ static void version(void)
>      printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n");
>  }
>  
> +static void print_rh_warning(void)
> +{
> +    printf("\nWARNING: Direct use of qemu-kvm from the command line is not supported by Red Hat.\n"
> +             "WARNING: Use libvirt as the stable management interface.\n"
> +             "WARNING: Some command line options listed here may not be available in future releases.\n\n");
> +}
> +
>  static void help(int exitcode)
>  {
>      version();
> +    print_rh_warning();
>      printf("usage: %s [options] [disk_image]\n\n"
>             "'disk_image' is a raw hard disk image for IDE hard disk 0\n\n",
>              error_get_progname());
> @@ -2012,6 +2020,7 @@ static void help(int exitcode)
>             "\n"
>             "When using -nographic, press 'ctrl-a h' to get some help.\n");
>  
> +    print_rh_warning();
>      exit(exitcode);
>  }
>  
> 

Wow, no whitelist anymore?!?!?

ACK

Paolo