From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtFbW-000423-VQ for qemu-devel@nongnu.org; Wed, 18 Dec 2013 06:48:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtFbR-0007Gc-0C for qemu-devel@nongnu.org; Wed, 18 Dec 2013 06:47:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtFbQ-0007GU-N5 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 06:47:48 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIBllHw004631 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 06:47:47 -0500 Message-ID: <52B18B81.6050608@redhat.com> Date: Wed, 18 Dec 2013 13:48:17 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-25-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-25-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 24/38] memory: use find_next_bit() to find dirty bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:26 PM, Juan Quintela wrote: > This operation is way faster than doing it bit by bit. > > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > include/exec/memory-internal.h | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index c04a92a..b017c2e 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -44,19 +44,15 @@ static inline bool cpu_physical_memory_get_dirty(ram_addr_t start, > ram_addr_t length, > unsigned client) > { > - ram_addr_t addr, end; > + unsigned long end, page, next; > > assert(client < DIRTY_MEMORY_NUM); > > - end = TARGET_PAGE_ALIGN(start + length); > - start &= TARGET_PAGE_MASK; > - for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { > - if (test_bit(addr >> TARGET_PAGE_BITS, > - ram_list.dirty_memory[client])) { > - return true; > - } > - } > - return false; > + end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS; > + page = start >> TARGET_PAGE_BITS; > + next = find_next_bit(ram_list.dirty_memory[client], end, page); > + > + return next < end; > } > > static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, > Reviewed-by: Orit Wasserman