From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtFdP-0005Fz-DV for qemu-devel@nongnu.org; Wed, 18 Dec 2013 06:49:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtFdJ-0007gB-De for qemu-devel@nongnu.org; Wed, 18 Dec 2013 06:49:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtFdJ-0007g3-4C for qemu-devel@nongnu.org; Wed, 18 Dec 2013 06:49:45 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIBninw018012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 06:49:44 -0500 Message-ID: <52B18BF9.1040501@redhat.com> Date: Wed, 18 Dec 2013 13:50:17 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-26-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-26-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 25/38] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:26 PM, Juan Quintela wrote: > We were setting a range of bits, so use bitmap_set(). > > Note: xen has always been wrong, and should have used start instead > of addr from the beginning. > > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > include/exec/memory-internal.h | 19 +++++++------------ > 1 file changed, 7 insertions(+), 12 deletions(-) > > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index b017c2e..4906cdf 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -81,19 +81,14 @@ static inline void cpu_physical_memory_set_dirty_flag(ram_addr_t addr, > static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, > ram_addr_t length) > { > - ram_addr_t addr, end; > + unsigned long end, page; > > - end = TARGET_PAGE_ALIGN(start + length); > - start &= TARGET_PAGE_MASK; > - for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { > - set_bit(addr >> TARGET_PAGE_BITS, > - ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION]); > - set_bit(addr >> TARGET_PAGE_BITS, > - ram_list.dirty_memory[DIRTY_MEMORY_VGA]); > - set_bit(addr >> TARGET_PAGE_BITS, > - ram_list.dirty_memory[DIRTY_MEMORY_CODE]); > - } > - xen_modified_memory(addr, length); > + end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS; > + page = start >> TARGET_PAGE_BITS; > + bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION], page, end - page); > + bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_VGA], page, end - page); > + bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_CODE], page, end - page); > + xen_modified_memory(start, length); > } > > static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start, > Reviewed-by: Orit Wasserman