From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtG7D-0000Ho-HA for qemu-devel@nongnu.org; Wed, 18 Dec 2013 07:20:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtG77-000824-Ft for qemu-devel@nongnu.org; Wed, 18 Dec 2013 07:20:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtG77-000820-6k for qemu-devel@nongnu.org; Wed, 18 Dec 2013 07:20:33 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBICKW5o029832 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Dec 2013 07:20:32 -0500 Message-ID: <52B18C16.6020605@redhat.com> Date: Wed, 18 Dec 2013 13:50:46 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-27-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-27-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 26/38] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:26 PM, Juan Quintela wrote: > We were clearing a range of bits, so use bitmap_clear(). > > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > include/exec/memory-internal.h | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index 4906cdf..e2f55ea 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -95,14 +95,12 @@ static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start, > ram_addr_t length, > unsigned client) > { > - ram_addr_t addr, end; > + unsigned long end, page; > > assert(client < DIRTY_MEMORY_NUM); > - end = TARGET_PAGE_ALIGN(start + length); > - start &= TARGET_PAGE_MASK; > - for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { > - clear_bit(addr >> TARGET_PAGE_BITS, ram_list.dirty_memory[client]); > - } > + end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS; > + page = start >> TARGET_PAGE_BITS; > + bitmap_clear(ram_list.dirty_memory[client], page, end - page); > } > > void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t end, > Reviewed-by: Orit Wasserman