From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43410)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1VtHr7-0002Qp-3L
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 09:12:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1VtHr0-0006zo-RA
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 09:12:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23502)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1VtHr0-0006zK-Is
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 09:12:02 -0500
Message-ID: <52B1ADD1.7050509@redhat.com>
Date: Wed, 18 Dec 2013 16:14:41 +0200
From: Gal Hammer <ghammer@redhat.com>
MIME-Version: 1.0
References: <1387103197-2238-1-git-send-email-ghammer@redhat.com>
	<20131216203245.GD6582@grmbl.mre> <52B01562.60700@redhat.com>
	<20131218053547.GB22209@grmbl.mre>
In-Reply-To: <20131218053547.GB22209@grmbl.mre>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4] char: restore read callback on a
 reattached (hotplug) chardev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Gerd Hoffmann <kraxel@redhat.com>

On 18/12/2013 07:35, Amit Shah wrote:

>> As far as I could tell the pty backend doesn't suffer from this
>> issue. That's why I didn't change anything there.
>
> pty_chr_update_read_handler() calls pty_chr_state(), which calls
> remove_fd_in_watch().

Yes, but the pty_chr_update_read_handler() isn't called on device 
removal so remove_fd_in_watch() is not executed.

However I did find that there was a problem in the pty backend that I 
missed and I'll post an updated patch.

Thanks,

     Gal.