Re: [Qemu-devel] [PATCH v3 0/4] QOM'ify apic and ioapic

["Andreas Färber" <afaerber@suse.de>]

Am 18.12.2013 18:57, schrieb Andreas Färber:
> Am 05.11.2013 11:16, schrieb xiaoqiang zhao:
>> xiaoqiang zhao (4):
>>   apic: Cleanup for QOM'ify
>>   apic: QOM'ify apic & icc_bus
>>   ioapic: Cleanup for QOM'ify
>>   ioapic: QOM'ify ioapic
> 
> Thanks, I have rebased and queued them with changes on qom-next:
> https://github.com/afaerber/qemu-cpu/commits/qom-next
> 
> In particular I have reverted TYPE_ introductions were unnecessary and
> reverted usages of TYPE_ constants for MemoryRegions. Also two white
> lines have been dropped. The ICC bus conversion has been split out as a
> separate step, using NULL errp as intermediate step since ignored.
> (CC'ing Peter C. and Luiz)

Oh and you forgot to convert the Xen APIC, I trivially fixed that.
(CC'ing Stefano)

> 
> However I still have doubts about the last patch and would appreciate
> feedback from Paolo, Anthony or anyone, cf. upcoming reply there.
> 
> Regards,
> Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg