qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fedorov Sergey <s.fedorov@samsung.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	a.basov@samsung.com,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Johannes Winter <johannes.winter@iaik.tugraz.at>
Subject: Re: [Qemu-devel] [RFC PATCH 17/21] target-arm: use c13_context field for CONTEXTIDR
Date: Thu, 19 Dec 2013 10:29:46 +0400	[thread overview]
Message-ID: <52B2925A.2030209@samsung.com> (raw)
In-Reply-To: <CAEgOgz5wmOW_nKhdJJY+HVFtLKPsjNwHG7-ytwOw=ORMkMA_Vg@mail.gmail.com>


On 12/19/2013 08:31 AM, Peter Crosthwaite wrote:
> On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov <s.fedorov@samsung.com> wrote:
>> Use c13_context field instead of c13_fcse for CONTEXTIDR register
>> definition.
> This a standalone (I.E. not TZ related) bug?
>
> Regards,
> peter

Yes, I think so. Then I will submit this patch separately soon.

Best regards,
Sergey Fedorov

>
>> Signed-off-by: Sergey Fedorov <s.fedorov@samsung.com>
>> ---
>>   target-arm/helper.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-arm/helper.c b/target-arm/helper.c
>> index 9442e08..e1e9762 100644
>> --- a/target-arm/helper.c
>> +++ b/target-arm/helper.c
>> @@ -359,7 +359,7 @@ static const ARMCPRegInfo cp_reginfo[] = {
>>         .resetvalue = 0, .writefn = fcse_write, .raw_writefn = raw_write, },
>>       { .name = "CONTEXTIDR", .cp = 15, .crn = 13, .crm = 0, .opc1 = 0, .opc2 = 1,
>>         .access = PL1_RW, .type = ARM_CP_BANKED,
>> -      .fieldoffset = offsetof(CPUARMState, cp15.c13_fcse),
>> +      .fieldoffset = offsetof(CPUARMState, cp15.c13_context),
>>         .resetvalue = 0, .writefn = contextidr_write, .raw_writefn = raw_write, },
>>       /* ??? This covers not just the impdef TLB lockdown registers but also
>>        * some v7VMSA registers relating to TEX remap, so it is overly broad.
>> --
>> 1.7.9.5
>>
>>

  reply	other threads:[~2013-12-19  6:30 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03  8:48 [Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone support Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 01/21] target-arm: add TrustZone CPU feature Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 02/21] target-arm: move SCR & VBAR into TrustZone register list Sergey Fedorov
2013-12-19  3:12   ` Peter Crosthwaite
2013-12-19  6:23     ` Fedorov Sergey
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 03/21] target-arm: adjust TTBCR for TrustZone feature Sergey Fedorov
2013-12-03 12:15   ` Peter Crosthwaite
2013-12-04  9:50     ` Fedorov Sergey
2013-12-04 10:52       ` Peter Crosthwaite
2013-12-19  3:18         ` Peter Crosthwaite
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 04/21] target-arm: preserve RAO/WI bits of ARMv7 SCTLR Sergey Fedorov
2013-12-03 12:17   ` Peter Crosthwaite
2013-12-04  9:55     ` Fedorov Sergey
2013-12-19  3:19       ` Peter Crosthwaite
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode Sergey Fedorov
2013-12-03 12:20   ` Peter Crosthwaite
2013-12-03 12:51     ` Peter Maydell
2013-12-04 10:01       ` Fedorov Sergey
2013-12-04 10:58         ` Peter Crosthwaite
2013-12-04 11:18           ` Peter Maydell
2013-12-04 12:33             ` Fedorov Sergey
2013-12-04 12:35               ` Peter Maydell
2013-12-19  3:26                 ` Peter Crosthwaite
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 06/21] target-arm: add arm_is_secure() helper Sergey Fedorov
2013-12-19  3:31   ` Peter Crosthwaite
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 07/21] target-arm: reject switching to monitor mode from non-secure state Sergey Fedorov
2013-12-19  3:44   ` Peter Crosthwaite
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 08/21] target-arm: adjust arm_current_pl() for TrustZone Sergey Fedorov
2013-12-03 12:23   ` Peter Crosthwaite
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 09/21] target-arm: adjust SCR CP15 register access rights Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 10/21] target-arm: add non-secure Translation Block flag Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 11/21] target-arm: implement CPACR register logic Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 12/21] target-arm: add NSACR support Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 13/21] target-arm: add SDER definition Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 14/21] target-arm: split TLB for secure state Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 15/21] target-arm: add banked coprocessor register type Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 16/21] target-arm: convert appropriate coprocessor registers to banked type Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 17/21] target-arm: use c13_context field for CONTEXTIDR Sergey Fedorov
2013-12-19  4:31   ` Peter Crosthwaite
2013-12-19  6:29     ` Fedorov Sergey [this message]
2013-12-19  6:32   ` Peter Crosthwaite
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers Sergey Fedorov
2013-12-19  4:37   ` Peter Crosthwaite
2013-12-19  7:27     ` Fedorov Sergey
2013-12-19 11:38       ` Peter Maydell
2013-12-19 12:44         ` Peter Crosthwaite
2013-12-19 13:39           ` Fedorov Sergey
2013-12-19 14:01             ` Peter Crosthwaite
2013-12-19 14:09               ` Peter Maydell
2013-12-20 14:12         ` Fedorov Sergey
2013-12-20 14:33           ` Peter Maydell
2013-12-20 14:38             ` Fedorov Sergey
2013-12-20 16:18               ` Fedorov Sergey
2013-12-22  1:08             ` Peter Crosthwaite
2013-12-22  7:59               ` Peter Maydell
2013-12-23  7:28               ` Fedorov Sergey
2013-12-23  7:43             ` Fedorov Sergey
2013-12-23  9:05               ` Peter Maydell
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 19/21] target-arm: add MVBAR support Sergey Fedorov
2013-12-19  4:41   ` Peter Crosthwaite
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 20/21] target-arm: implement SMC instruction Sergey Fedorov
2013-12-03  8:48 ` [Qemu-devel] [RFC PATCH 21/21] target-arm: implement IRQ/FIQ routing to Monitor mode Sergey Fedorov
2013-12-04 10:08 ` [Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone support Fedorov Sergey
2013-12-04 11:10   ` Peter Crosthwaite
2013-12-04 11:13   ` Peter Maydell
2013-12-04 12:48     ` Fedorov Sergey
2013-12-19  4:56       ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B2925A.2030209@samsung.com \
    --to=s.fedorov@samsung.com \
    --cc=a.basov@samsung.com \
    --cc=johannes.winter@iaik.tugraz.at \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).