From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtaRO-0004U6-Hu for qemu-devel@nongnu.org; Thu, 19 Dec 2013 05:02:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtaRF-00008Z-DM for qemu-devel@nongnu.org; Thu, 19 Dec 2013 05:02:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtaRF-00008G-6W for qemu-devel@nongnu.org; Thu, 19 Dec 2013 05:02:41 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJA2cvw023077 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 Dec 2013 05:02:39 -0500 Message-ID: <52B2C45F.6030206@redhat.com> Date: Thu, 19 Dec 2013 12:03:11 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-33-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-33-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* api for tracking dirty pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:26 PM, Juan Quintela wrote: > Performance is important in this function, and we want to optimize even further. > > Signed-off-by: Juan Quintela > --- > kvm-all.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index 3937754..308dfba 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -31,6 +31,7 @@ > #include "sysemu/kvm.h" > #include "qemu/bswap.h" > #include "exec/memory.h" > +#include "exec/ram_addr.h" > #include "exec/address-spaces.h" > #include "qemu/event_notifier.h" > #include "trace.h" > @@ -382,6 +383,7 @@ static int kvm_get_dirty_pages_log_range(MemoryRegionSection *section, > unsigned int i, j; > unsigned long page_number, c; > hwaddr addr, addr1; > + ram_addr_t ram_addr; > unsigned int pages = int128_get64(section->size) / getpagesize(); > unsigned int len = (pages + HOST_LONG_BITS - 1) / HOST_LONG_BITS; > unsigned long hpratio = getpagesize() / TARGET_PAGE_SIZE; > @@ -399,8 +401,9 @@ static int kvm_get_dirty_pages_log_range(MemoryRegionSection *section, > page_number = (i * HOST_LONG_BITS + j) * hpratio; > addr1 = page_number * TARGET_PAGE_SIZE; > addr = section->offset_within_region + addr1; > - memory_region_set_dirty(section->mr, addr, > - TARGET_PAGE_SIZE * hpratio); > + ram_addr = section->mr->ram_addr + addr; > + cpu_physical_memory_set_dirty_range(ram_addr, > + TARGET_PAGE_SIZE * hpratio); > } while (c != 0); > } > } > Reviewed-by: Orit Wasserman